Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources: Give button elements white-space: normal again. #13445

Merged
merged 1 commit into from Sep 30, 2016
Merged

resources: Give button elements white-space: normal again. #13445

merged 1 commit into from Sep 30, 2016

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Sep 26, 2016 •
edited by larsbergstrom

Fixes Twitter.

Originally regressed in 0a86543.

r? @metajack

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 26, 2016
@highfive
Copy link

warning Warning warning

  • These commits include an empty title element (<title></title>). Consider adding appropriate metadata.

@Ms2ger Ms2ger mentioned this pull request Sep 27, 2016
Closed
@mbrubeck
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 2d31546 has been approved by mbrubeck

@highfive highfive assigned mbrubeck and unassigned metajack Sep 27, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 27, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 2d31546 with merge 6b302ba...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 28, 2016
@KiChjang
Copy link
Contributor

@bors-servo retry

1 similar comment
@mbrubeck
Copy link
Contributor

@bors-servo retry

@mbrubeck mbrubeck added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 30, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 2d31546 with merge f3736e1...

bors-servo pushed a commit that referenced this pull request Sep 30, 2016
Auto merge of #13445 - pcwalton:button-whitespace, r=mbrubeck
f3736e1 
resources: Give button elements `white-space: normal` again.

Fixes Twitter.

Originally regressed in 0a86543.

r? @metajack

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13445)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 30, 2016
@jdm
Copy link
Member

jdm commented Sep 30, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 2d31546 with merge ddb95cb...

bors-servo pushed a commit that referenced this pull request Sep 30, 2016
Auto merge of #13445 - pcwalton:button-whitespace, r=mbrubeck
ddb95cb 
resources: Give button elements `white-space: normal` again.

Fixes Twitter.

Originally regressed in 0a86543.

r? @metajack

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13445)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 30, 2016
@bors-servo
Copy link
Contributor

💔 Test failed - arm32

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 30, 2016
@larsbergstrom
Copy link
Contributor

@bors-servo retry

  • infra

@bors-servo
Copy link
Contributor

⌛ Testing commit 2d31546 with merge 6693c92...

bors-servo pushed a commit that referenced this pull request Sep 30, 2016
Auto merge of #13445 - pcwalton:button-whitespace, r=mbrubeck
6693c92 
resources: Give button elements `white-space: normal` again.

Fixes Twitter.

Originally regressed in 0a86543.

r? @metajack

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13445)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 30, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 2d31546 into servo:master Sep 30, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pcwalton @highfive @mbrubeck @bors-servo @KiChjang @jdm @larsbergstrom @metajack