Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass a MutableHandle to fill_property_descriptor. #13449

Merged
merged 1 commit into from Sep 30, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 27, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Sep 27, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/proxyhandler.rs, components/script/dom/browsingcontext.rs
@highfive
Copy link

highfive commented Sep 27, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Sep 27, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2016

📌 Commit 6928fbf has been approved by jdm

@highfive highfive assigned jdm and unassigned metajack Sep 27, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Sep 29, 2016

Testing commit 6928fbf with merge 479ac68...

bors-servo added a commit that referenced this pull request Sep 29, 2016
Pass a MutableHandle to fill_property_descriptor.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13449)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 29, 2016

💔 Test failed - linux-rel

@jdm
Copy link
Member

jdm commented Sep 29, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Sep 29, 2016

Testing commit 6928fbf with merge f8bc632...

bors-servo added a commit that referenced this pull request Sep 29, 2016
Pass a MutableHandle to fill_property_descriptor.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13449)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 29, 2016

💔 Test failed - linux-rel

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 30, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2016

Testing commit 6928fbf with merge ec4f61e...

bors-servo added a commit that referenced this pull request Sep 30, 2016
Pass a MutableHandle to fill_property_descriptor.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13449)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2016

@bors-servo bors-servo merged commit 6928fbf into master Sep 30, 2016
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
dependency-ci Failed dependency checks
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the fill_property_descriptor branch Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.