New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sequential focus navigation #13460
Closed
+154
−2
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
| @@ -2203,6 +2203,19 @@ impl VirtualMethods for Element { | ||
| return; | ||
| } | ||
|
|
||
| if self.is_focusable_area() { | ||
| let doc = document_from_node(self); | ||
| let children = self.upcast::<Node>().traverse_preorder(); | ||
|
|
||
| for child in children { | ||
| if let Some(element) = child.downcast::<Element>() { | ||
| if element.is_focusable_area() && !element.disabled_state() { | ||
| doc.add_focusable_element(element); | ||
| } | ||
| } | ||
| } | ||
| } | ||
nox
Member
|
||
|
|
||
| if let Some(ref value) = *self.id_attribute.borrow() { | ||
| let doc = document_from_node(self); | ||
| doc.register_named_element(self, value.clone()); | ||
| @@ -2216,6 +2229,9 @@ impl VirtualMethods for Element { | ||
| return; | ||
| } | ||
|
|
||
| let doc = document_from_node(self); | ||
| doc.remove_focusable_element(self); | ||
|
|
||
| if let Some(ref value) = *self.id_attribute.borrow() { | ||
| let doc = document_from_node(self); | ||
| doc.unregister_named_element(self, value.clone()); | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
You can use
Iterator::positionfor this.