Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport letter-spacing in stylo #13473
Merged
Conversation
highfive
commented
Sep 28, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 28, 2016
|
|
| @@ -1523,6 +1523,12 @@ fn static_assert() { | |||
|
|
|||
| <%call expr="impl_coord_copy('line_height', 'mLineHeight')"></%call> | |||
|
|
|||
| pub fn set_letter_spacing(&mut self, v: longhands::letter_spacing::computed_value::T) { | |||
| self.gecko.mLetterSpacing.set_value(CoordDataValue::Coord(v.0.map(|au| au.0).unwrap_or(0))); | |||
This comment has been minimized.
This comment has been minimized.
|
This works.
@bors-servo r=Manishearth,Wafflespeanut |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 30, 2016
…afflespeanut Support letter-spacing in stylo Fixes #12823. r? @Manishearth **This needs to be tested!** <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13473) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
KiChjang commentedSep 28, 2016
•
edited by wafflespeanut
Fixes #12823.
r? @Manishearth
This needs to be tested!
This change is