Remove orphaned gfx::text::shaper code #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon. |
|
There were two copies of the shaper code for a short period of time and the non-orphaned version fixed the original issue in commit c850b59. |
|
This looks great: r+. Tested locally on Linux and OSX (our buildbot servers are down). |
larsbergstrom
added a commit
that referenced
this pull request
Dec 7, 2013
Remove orphaned gfx::text::shaper code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shaper code referenced in this issue is no longer being used. It
was removed in commit a535f22, but
later reintroduced due to a merge conflict in commit
d64d987.
Fixes #163.