Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIFrame elements now manage FrameIds rather than the constellation. #13498
Conversation
highfive
commented
Sep 29, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 29, 2016
|
|
|
Looks good - just one comment request :) |
| next_pipeline_namespace_id: PipelineNamespaceId(0), | ||
| root_frame_id: None, | ||
| next_frame_id: FrameId(0), | ||
| next_pipeline_namespace_id: PipelineNamespaceId(1), |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@asajeffrey Nice! Squash and r=me |
asajeffrey
force-pushed the
asajeffrey:script-iframe-stores-frameid
branch
from
3a06846
to
b400461
|
Squashed. Thanks! @bors-servo r=glennw |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 6, 2016
IFrame elements now manage FrameIds rather than the constellation. <!-- Please describe your changes on the following line: --> This PR stores the FrameId as well as the PipelineId in an html iframe. The iframes are now responsible for creating frame ids, not the constellation. This is the first step in fixing #633, because it means we know the frame id of each script thread when it is created. It also means we can share the frame id, for example using it in the debugger. cc @jdm, @ConnorGBrewster and @ejpbruel. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's a refactoring. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13498) <!-- Reviewable:end -->
|
|
|
|
asajeffrey
force-pushed the
asajeffrey:script-iframe-stores-frameid
branch
from
b400461
to
466dcd8
asajeffrey
force-pushed the
asajeffrey:script-iframe-stores-frameid
branch
from
466dcd8
to
8ecb13b
|
Rebased, and fixed test failure due to left-over fake root pipeline. @bors-servo r=glennw |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 7, 2016
IFrame elements now manage FrameIds rather than the constellation. <!-- Please describe your changes on the following line: --> This PR stores the FrameId as well as the PipelineId in an html iframe. The iframes are now responsible for creating frame ids, not the constellation. This is the first step in fixing #633, because it means we know the frame id of each script thread when it is created. It also means we can share the frame id, for example using it in the debugger. cc @jdm, @ConnorGBrewster and @ejpbruel. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's a refactoring. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13498) <!-- Reviewable:end -->
|
|
highfive
added
S-tests-failed
S-awaiting-review
and removed
S-awaiting-merge
S-tests-failed
labels
asajeffrey
force-pushed the
asajeffrey:script-iframe-stores-frameid
branch
from
d89d2f3
to
f53408d
|
Fixed failing unit tests by adding a |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 7, 2016
IFrame elements now manage FrameIds rather than the constellation. <!-- Please describe your changes on the following line: --> This PR stores the FrameId as well as the PipelineId in an html iframe. The iframes are now responsible for creating frame ids, not the constellation. This is the first step in fixing #633, because it means we know the frame id of each script thread when it is created. It also means we can share the frame id, for example using it in the debugger. cc @jdm, @ConnorGBrewster and @ejpbruel. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's a refactoring. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13498) <!-- Reviewable:end -->
|
|
This was referenced Oct 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedSep 29, 2016
•
edited by larsbergstrom
This PR stores the FrameId as well as the PipelineId in an html iframe. The iframes are now responsible for creating frame ids, not the constellation.
This is the first step in fixing #633, because it means we know the frame id of each script thread when it is created. It also means we can share the frame id, for example using it in the debugger.
cc @jdm, @ConnorGBrewster and @ejpbruel.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is