New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A test case change is added to #13442: Fix #12193 Servo displays upper level Thai character in wrong place. #13506

Merged
merged 2 commits into from Feb 1, 2017

Conversation

Projects
None yet
7 participants
@veer66
Contributor

veer66 commented Sep 29, 2016

A test case change is added to #13442

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 29, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

highfive commented Sep 29, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 29, 2016

warning Warning warning

  • This pull request modifies the contents of
    tests/wpt/css-tests/, which are overwriten occasionally whenever the
    directory is synced from upstream.

highfive commented Sep 29, 2016

warning Warning warning

  • This pull request modifies the contents of
    tests/wpt/css-tests/, which are overwriten occasionally whenever the
    directory is synced from upstream.
@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 29, 2016

Member

Rather than modifying the test, it would be better to duplicate it in tests/wpt/mozilla/tests/mozilla.

Member

jdm commented Sep 29, 2016

Rather than modifying the test, it would be better to duplicate it in tests/wpt/mozilla/tests/mozilla.

@veer66

This comment has been minimized.

Show comment
Hide comment
@veer66

veer66 Sep 29, 2016

Contributor

@jdm

  • Should I keep file name the same i.e. word-break-break-all-007.htm?
  • If I don't modify tests/wpt/css-tests/css-text-3_dev/html/word-break-break-all-007.htm, can this patch pass this test case?
Contributor

veer66 commented Sep 29, 2016

@jdm

  • Should I keep file name the same i.e. word-break-break-all-007.htm?
  • If I don't modify tests/wpt/css-tests/css-text-3_dev/html/word-break-break-all-007.htm, can this patch pass this test case?
@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 29, 2016

Member
  • Yes
  • No
Member

jdm commented Sep 29, 2016

  • Yes
  • No
@veer66

This comment has been minimized.

Show comment
Hide comment
@veer66

veer66 Sep 29, 2016

Contributor

@jdm So adding a new test case does not solve the issue in #13442?

Contributor

veer66 commented Sep 29, 2016

@jdm So adding a new test case does not solve the issue in #13442?

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 29, 2016

Member

The issue I'm interested in solving is a lack of tests that fail before the change and pass after it. It doesn't matter to me if the original test still fails, because we know why it fails. Does that make sense?

Member

jdm commented Sep 29, 2016

The issue I'm interested in solving is a lack of tests that fail before the change and pass after it. It doesn't matter to me if the original test still fails, because we know why it fails. Does that make sense?

@veer66

This comment has been minimized.

Show comment
Hide comment
@veer66

veer66 Sep 30, 2016

Contributor

That sounds good.

Contributor

veer66 commented Sep 30, 2016

That sounds good.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Oct 29, 2016

Member

Any progress, @veer66?

Member

jdm commented Oct 29, 2016

Any progress, @veer66?

@KiChjang

This comment has been minimized.

Show comment
Hide comment
@KiChjang

KiChjang Dec 14, 2016

Member

Looks like this is abandoned, needs a new owner.

Member

KiChjang commented Dec 14, 2016

Looks like this is abandoned, needs a new owner.

@veer66

This comment has been minimized.

Show comment
Hide comment
@veer66

veer66 Dec 15, 2016

Contributor

There is no progress. I hope I can resume working on this in 2017.

Contributor

veer66 commented Dec 15, 2016

There is no progress. I hope I can resume working on this in 2017.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm
Member

jdm commented Jan 19, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 19, 2017

Contributor

⌛️ Trying commit 02ee820 with merge e58a522...

Contributor

bors-servo commented Jan 19, 2017

⌛️ Trying commit 02ee820 with merge e58a522...

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jan 19, 2017

Contributor

💔 Test failed - linux-rel-css

Contributor

bors-servo commented Jan 19, 2017

💔 Test failed - linux-rel-css

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Jan 19, 2017

Member
  ▶ PASS [expected FAIL] /css-text-3_dev/html/word-break-break-all-007.htm

Woooooooo
This is totally ready to merge if word-break-break-all-007.htm.ini is removed.

Member

jdm commented Jan 19, 2017

  ▶ PASS [expected FAIL] /css-text-3_dev/html/word-break-break-all-007.htm

Woooooooo
This is totally ready to merge if word-break-break-all-007.htm.ini is removed.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm
Member

jdm commented Feb 1, 2017

@highfive highfive assigned mbrubeck and unassigned larsbergstrom Feb 1, 2017

@mbrubeck

This comment has been minimized.

Show comment
Hide comment
@mbrubeck

mbrubeck Feb 1, 2017

Contributor

r=mbrubeck with that minor bug in the test fixed.

Contributor

mbrubeck commented Feb 1, 2017

r=mbrubeck with that minor bug in the test fixed.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Feb 1, 2017

Member

@bors-servo: r=mbrubeck

Member

jdm commented Feb 1, 2017

@bors-servo: r=mbrubeck

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 1, 2017

Contributor

📌 Commit a83fd07 has been approved by mbrubeck

Contributor

bors-servo commented Feb 1, 2017

📌 Commit a83fd07 has been approved by mbrubeck

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 1, 2017

Contributor

⌛️ Testing commit a83fd07 with merge d161f6e...

Contributor

bors-servo commented Feb 1, 2017

⌛️ Testing commit a83fd07 with merge d161f6e...

bors-servo added a commit that referenced this pull request Feb 1, 2017

Auto merge of #13506 - veer66:master, r=mbrubeck
A test case change is added to #13442: Fix  #12193 Servo displays upper level Thai character in wrong place.

<!-- Please describe your changes on the following line: -->

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13506)

<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment

@bors-servo bors-servo merged commit a83fd07 into servo:master Feb 1, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment