Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A test case change is added to #13442: Fix #12193 Servo displays upper level Thai character in wrong place. #13506

Merged
merged 2 commits into from Feb 1, 2017
Merged

A test case change is added to #13442: Fix #12193 Servo displays upper level Thai character in wrong place. #13506

merged 2 commits into from Feb 1, 2017

Conversation

@veer66
Copy link
Contributor

veer66 commented Sep 29, 2016 •
edited by larsbergstrom

A test case change is added to #13442

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Sep 29, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.
@highfive
Copy link

highfive commented Sep 29, 2016

warning Warning warning

  • This pull request modifies the contents of
    tests/wpt/css-tests/, which are overwriten occasionally whenever the
    directory is synced from upstream.
@veer66 veer66 mentioned this pull request Sep 29, 2016
Closed
@jdm
Copy link
Member

jdm commented Sep 29, 2016

Rather than modifying the test, it would be better to duplicate it in tests/wpt/mozilla/tests/mozilla.
@veer66
Copy link
Contributor Author

veer66 commented Sep 29, 2016

@jdm

  • Should I keep file name the same i.e. word-break-break-all-007.htm?
  • If I don't modify tests/wpt/css-tests/css-text-3_dev/html/word-break-break-all-007.htm, can this patch pass this test case?
@jdm
Copy link
Member

jdm commented Sep 29, 2016

  • Yes
  • No
@veer66
Copy link
Contributor Author

veer66 commented Sep 29, 2016

@jdm So adding a new test case does not solve the issue in #13442?
@jdm
Copy link
Member

jdm commented Sep 29, 2016

The issue I'm interested in solving is a lack of tests that fail before the change and pass after it. It doesn't matter to me if the original test still fails, because we know why it fails. Does that make sense?
@veer66
Copy link
Contributor Author

veer66 commented Sep 30, 2016

That sounds good.
@jdm
Copy link
Member

jdm commented Oct 29, 2016

Any progress, @veer66?
@KiChjang
Copy link
Member

KiChjang commented Dec 14, 2016

Looks like this is abandoned, needs a new owner.
@veer66
Copy link
Contributor Author

veer66 commented Dec 15, 2016

There is no progress. I hope I can resume working on this in 2017.
@veer66 veer66 force-pushed the veer66:master branch from 01094c5 to 5d184f3 Jan 19, 2017
@veer66 veer66 force-pushed the veer66:master branch from 5d184f3 to 02ee820 Jan 19, 2017
@jdm
Copy link
Member

jdm commented Jan 19, 2017

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2017

⌛ Trying commit 02ee820 with merge e58a522...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2017

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Jan 19, 2017 

  ▶ PASS [expected FAIL] /css-text-3_dev/html/word-break-break-all-007.htm

Woooooooo
This is totally ready to merge if word-break-break-all-007.htm.ini is removed.
@jdm jdm removed the S-tests-failed label Jan 19, 2017
@veer66 @jdm
Fix #12193 Servo displays upper level Thai character in wrong place.
c695674
@jdm jdm force-pushed the veer66:master branch from 02ee820 to f78ea3a Feb 1, 2017
@jdm
Copy link
Member

jdm commented Feb 1, 2017

r? @mbrubeck
@highfive highfive assigned mbrubeck and unassigned larsbergstrom Feb 1, 2017
@mbrubeck
mbrubeck requested changes Feb 1, 2017
View changes
tests/wpt/mozilla/tests/css/complex_glyphs_ref.html Outdated
<!doctype html>
<meta charset="utf-8">
<body>
ยิน&#X200Bดี

This comment has been minimized.

Sign in to view
@mbrubeck

mbrubeck Feb 1, 2017

Contributor

There's a missing semicolon after &#X200B;
@mbrubeck
Copy link
Contributor

mbrubeck commented Feb 1, 2017

r=mbrubeck with that minor bug in the test fixed.
@veer66 @jdm
reftest for issue #12193 Servo displays upper level Thai character in…
Loading status checks…
a83fd07 
… wrong place.
@jdm jdm force-pushed the veer66:master branch from f78ea3a to a83fd07 Feb 1, 2017
@jdm
Copy link
Member

jdm commented Feb 1, 2017

@bors-servo: r=mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2017

📌 Commit a83fd07 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2017

⌛ Testing commit a83fd07 with merge d161f6e...
bors-servo added a commit that referenced this pull request Feb 1, 2017
@bors-servo
Auto merge of #13506 - veer66:master, r=mbrubeck
Loading status checks…
d161f6e 
A test case change is added to #13442: Fix  #12193 Servo displays upper level Thai character in wrong place.

<!-- Please describe your changes on the following line: -->

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13506)

<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit a83fd07 into servo:master Feb 1, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrubeck mbrubeck

Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@veer66 @highfive @jdm @KiChjang @bors-servo @mbrubeck @larsbergstrom
You can’t perform that action at this time.