Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the error codes instead of implicitly returning None #13513

Merged
merged 1 commit into from Oct 1, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -246,9 +246,7 @@ def test_unit(self, test_name=None, package=None):

if features:
args += ["--features", "%s" % ' '.join(features)]
result = call(args, env=env, cwd=self.servo_crate())
if result != 0:
return result
return call(args, env=env, cwd=self.servo_crate())

# Run style tests with the testing feature
if has_style:
@@ -257,9 +255,7 @@ def test_unit(self, test_name=None, package=None):
args += ["%s" % ' '.join(features + ["testing"])]
else:
args += ["testing"]
result = call(args, env=env, cwd=self.servo_crate())
if result != 0:
return result
return call(args, env=env, cwd=self.servo_crate())

@Command('test-stylo',
description='Run stylo unit tests',
@@ -273,10 +269,7 @@ def test_stylo(self):
env["CARGO_TARGET_DIR"] = path.join(self.context.topdir, "target", "geckolib").encode("UTF-8")

with cd(path.join("ports", "geckolib")):
result = call(["cargo", "test", "-p", "stylo_tests"], env=env)

if result != 0:
return result
return call(["cargo", "test", "-p", "stylo_tests"], env=env)

@Command('test-compiletest',
description='Run compiletests',
@@ -333,9 +326,7 @@ def test_compiletest(self, test_name=None, package=None, release=False):
else:
env["BUILD_MODE"] = "debug"

result = call(args, env=env, cwd=self.servo_crate())
if result != 0:
return result
return call(args, env=env, cwd=self.servo_crate())

@Command('test-content',
description='Run the content tests',
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.