Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMoved pub_domains to net_traits and did a spring clean. #13517
Merged
Conversation
highfive
commented
Sep 29, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ |
|
|
|
Thanks! |
bors-servo
added a commit
that referenced
this pull request
Oct 1, 2016
Moved pub_domains to net_traits and did a spring clean. <!-- Please describe your changes on the following line: --> Moved the `pub_domains` module from `net` into `net_traits`, so it can be used by crates which don't depend on `net` (in particular `constellation`, which can use the crate for testing similar-origin). I also did quite a bit of tidying up, the functions now do no heap allocation, previously there was quite a bit of String allocation going on. This is the next step to fixing #633. cc @jdm --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes (new unit tests) <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13517) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedSep 29, 2016
•
edited by larsbergstrom
Moved the
pub_domainsmodule fromnetintonet_traits, so it can be used by crates which don't depend onnet(in particularconstellation, which can use the crate for testing similar-origin).I also did quite a bit of tidying up, the functions now do no heap allocation, previously there was quite a bit of String allocation going on.
This is the next step to fixing #633. cc @jdm
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is