Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove --use-msvc-mangling out from clang flags. #13518
Merged
Conversation
highfive
commented
Sep 30, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 30, 2016
|
|
|
@bors-servo: r+ Good catch! Can't wait to get all this stuff in CI so this doesn't happen, sorry. |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 1, 2016
Move --use-msvc-mangling out from clang flags. `--use-msvc-mangling` is not a clang flag, but a flag for bindgen. r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13518) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 1, 2016
Move --use-msvc-mangling out from clang flags. `--use-msvc-mangling` is not a clang flag, but a flag for bindgen. r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13518) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 1, 2016
Move --use-msvc-mangling out from clang flags. `--use-msvc-mangling` is not a clang flag, but a flag for bindgen. r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13518) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
upsuper commentedSep 30, 2016
•
edited by larsbergstrom
--use-msvc-manglingis not a clang flag, but a flag for bindgen.r? @emilio
This change is