Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore stylesheet links with an empty href. #13525

Merged
merged 3 commits into from Oct 2, 2016
Merged

Ignore stylesheet links with an empty href. #13525

merged 3 commits into from Oct 2, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 30, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Sep 30, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmllinkelement.rs
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 30, 2016

Noticed working toward #13462.

@emilio
Copy link
Member

emilio commented Oct 2, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2016

📌 Commit e2f5ce4 has been approved by emilio

@highfive highfive assigned emilio and unassigned cbrewster Oct 2, 2016
bors-servo added a commit that referenced this pull request Oct 2, 2016
Ignore stylesheet links with an empty href.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13525)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2016

Testing commit e2f5ce4 with merge c6b44f7...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2016

💔 Test failed - mac-rel-wpt2

@jdm
Copy link
Member

jdm commented Oct 2, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2016

Testing commit e2f5ce4 with merge 3eb6fc4...

bors-servo added a commit that referenced this pull request Oct 2, 2016
Ignore stylesheet links with an empty href.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13525)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2016

@bors-servo bors-servo merged commit e2f5ce4 into master Oct 2, 2016
2 of 4 checks passed
2 of 4 checks passed
dependency-ci An error occured
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@emilio emilio deleted the empty-href branch Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.