Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include openSUSE dependencies #13534

Merged
merged 1 commit into from Oct 1, 2016
Merged

Update README.md to include openSUSE dependencies #13534

merged 1 commit into from Oct 1, 2016

Conversation

@j-koreth
Copy link
Contributor

j-koreth commented Oct 1, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because the only file changed is the README.md to include openSUSE dependencies

This change is Reviewable
@j-koreth
Update README.md to include openSUSE dependencies
Loading status checks…
177d6b7
@highfive
Copy link

highfive commented Oct 1, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.
@KiChjang
Copy link
Member

KiChjang commented Oct 1, 2016

@j-koreth Just a tip, next time you create a PR, try not to make commits on your fork's master branch. Instead, check out a feature branch and commit to that. That way your changes would not be affected when you pull from upstream. Thanks!

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2016

📌 Commit 177d6b7 has been approved by jdm
@j-koreth
Copy link
Contributor Author

j-koreth commented Oct 1, 2016

@KiChjang Thanks for the advice and I'm sorry for having 4 commits like that. I didn't realize you can do it in other ways, I guess I have a lot of learning to do :P
@j-koreth j-koreth closed this Oct 1, 2016
@j-koreth j-koreth reopened this Oct 1, 2016
@j-koreth
Copy link
Contributor Author

j-koreth commented Oct 1, 2016

Oops didn't mean to close this, sorry about that
@wafflespeanut
Copy link
Member

wafflespeanut commented Oct 1, 2016

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #13517
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2016

📌 Commit 177d6b7 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2016

⌛ Testing commit 177d6b7 with merge 3ed96f6...
bors-servo added a commit that referenced this pull request Oct 1, 2016
@bors-servo
Auto merge of #13534 - j-koreth:master, r=jdm
Loading status checks…
3ed96f6 
Update README.md to include openSUSE dependencies

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the only file changed is the README.md to include openSUSE dependencies

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13534)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2016

💔 Test failed - mac-rel-wpt2
@KiChjang
Copy link
Member

KiChjang commented Oct 1, 2016

@bors-servo retry
@j-koreth
Copy link
Contributor Author

j-koreth commented Oct 1, 2016 •
edited

Wait how can a change to the README.md file fail tests?
Oh all right thanks @KiChjang
@KiChjang
Copy link
Member

KiChjang commented Oct 1, 2016

@j-koreth It has nothing to do with your changes, the test failure is a known intermittent.
@j-koreth
Copy link
Contributor Author

j-koreth commented Oct 1, 2016

Oh all right thanks @KiChjang, I only saw your earlier #13133 comment after submitting my comment
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2016

⌛ Testing commit 177d6b7 with merge 34fa38f...
bors-servo added a commit that referenced this pull request Oct 1, 2016
@bors-servo
Auto merge of #13534 - j-koreth:master, r=jdm
Loading status checks…
34fa38f 
Update README.md to include openSUSE dependencies

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the only file changed is the README.md to include openSUSE dependencies

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13534)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 177d6b7 into servo:master Oct 1, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@j-koreth @highfive @KiChjang @bors-servo @wafflespeanut @jdm
You can’t perform that action at this time.