Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mako out of wptrunner required packages #13562

Merged
merged 2 commits into from Oct 3, 2016
Merged

Move mako out of wptrunner required packages #13562

merged 2 commits into from Oct 3, 2016

Conversation

@jdm
Copy link
Member

jdm commented Oct 3, 2016 •
edited by larsbergstrom

There was a review comment about this in #13382 (comment) that was never addressed.

This change is Reviewable
jdm added 2 commits Oct 3, 2016
@jdm
Add mako to required python packages
Loading status checks…
cb0709a 
It's required for the OSMesa build process.
@jdm
Remove mako from required python packages for wptrunner
Loading status checks…
65fde47
@highfive
Copy link

highfive commented Oct 3, 2016

Heads up! This PR modifies the following files:
@jgraham
Copy link
Contributor

jgraham commented Oct 3, 2016

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable
@jgraham
Copy link
Contributor

jgraham commented Oct 3, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2016

📌 Commit 65fde47 has been approved by jgraham
@highfive highfive assigned jgraham and unassigned nox Oct 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2016

⌛ Testing commit 65fde47 with merge c10de40...
bors-servo added a commit that referenced this pull request Oct 3, 2016
@bors-servo
Auto merge of #13562 - servo:jdm-patch-5, r=jgraham
Loading status checks…
c10de40 
Move mako out of wptrunner required packages

There was a review comment about this in #13382 (comment) that was never addressed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13562)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 65fde47 into master Oct 3, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
dependency-ci Failed dependency checks
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-5 branch Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgraham jgraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @jgraham @bors-servo @nox
You can’t perform that action at this time.