New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NS_FONT_STRETCH_* consts and regenerate bindings #13566

Merged
merged 2 commits into from Oct 4, 2016

Conversation

Projects
None yet
4 participants
@wafflespeanut
Copy link
Member

wafflespeanut commented Oct 4, 2016

Depends on servo/rust-bindgen#74


  • ./mach build-geckolib does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they're autogenerated

Once that merges, r? @Manishearth


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Oct 4, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/structs_debug.rs, components/style/binding_tools/regen.py, components/style/gecko_bindings/structs_release.rs
@highfive

This comment has been minimized.

Copy link

highfive commented Oct 4, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Oct 4, 2016

r=me. I might replace the regen with one from my own machine to avoid churn

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Oct 4, 2016

Could you only include the consts changes? git reset structs_foo.rs; git add -p structs_foo.rs will work for selecting diff chunks.

@wafflespeanut wafflespeanut force-pushed the wafflespeanut:consts branch from 7c34fcc to 68d25d9 Oct 4, 2016

@wafflespeanut

This comment has been minimized.

Copy link
Member Author

wafflespeanut commented Oct 4, 2016

It now has the constants generated by the script.

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Oct 4, 2016

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Oct 4, 2016

📌 Commit 68d25d9 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Oct 4, 2016

⌛️ Testing commit 68d25d9 with merge 6f8bf29...

bors-servo added a commit that referenced this pull request Oct 4, 2016

Auto merge of #13566 - Wafflespeanut:consts, r=Manishearth
Add NS_FONT_STRETCH_* consts and regenerate bindings

<!-- Please describe your changes on the following line: -->

Depends on servo/rust-bindgen#74

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because they're autogenerated

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Once that merges, r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13566)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Oct 4, 2016

@bors-servo bors-servo merged commit 68d25d9 into servo:master Oct 4, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@wafflespeanut wafflespeanut deleted the wafflespeanut:consts branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment