Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 4, 2016

Depends on rust-lang/rust-bindgen#74


  • ./mach build-geckolib does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they're autogenerated

Once that merges, r? @Manishearth


This change is Reviewable

@ghost ghost added the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Oct 4, 2016
@highfive
Copy link

highfive commented Oct 4, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/structs_debug.rs, components/style/binding_tools/regen.py, components/style/gecko_bindings/structs_release.rs

@highfive
Copy link

highfive commented Oct 4, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 4, 2016
@Manishearth
Copy link
Member

r=me. I might replace the regen with one from my own machine to avoid churn

@Manishearth
Copy link
Member

Could you only include the consts changes? git reset structs_foo.rs; git add -p structs_foo.rs will work for selecting diff chunks.

@ghost
Copy link
Author

ghost commented Oct 4, 2016

It now has the constants generated by the script.

@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 68d25d9 has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 4, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 68d25d9 with merge 6f8bf29...

bors-servo pushed a commit that referenced this pull request Oct 4, 2016
Add NS_FONT_STRETCH_* consts and regenerate bindings

<!-- Please describe your changes on the following line: -->

Depends on rust-lang/rust-bindgen#74

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because they're autogenerated

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Once that merges, r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13566)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo merged commit 68d25d9 into servo:master Oct 4, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 4, 2016
@ghost ghost deleted the consts branch October 5, 2016 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants