Add support for 'font-stretch' in geckolib #13570

Merged
merged 1 commit into from Oct 4, 2016

Projects

None yet

4 participants

@Wafflespeanut
Member
Wafflespeanut commented Oct 4, 2016 edited

  • ./mach build-geckolib does not report any errors
  • ./mach test-tidy does not report any errors

r? @Manishearth


This change is Reviewable

@Wafflespeanut Wafflespeanut Add support for 'font-stretch'
361f372
@Manishearth Manishearth was assigned by highfive Oct 4, 2016
@highfive
highfive commented Oct 4, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs
@highfive
highfive commented Oct 4, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Member

r=me if screenshots work

(fwiw screenshots don't count as tests 😄, the PR text is talking about automated tests. For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons)

@Wafflespeanut
Member

@Manishearth Yeah, but we don't have any other tests 😄

@Wafflespeanut
Member

screenshot

@bors-servo r=Manishearth

@bors-servo
Contributor

📌 Commit 361f372 has been approved by Manishearth

@bors-servo
Contributor

⌛️ Testing commit 361f372 with merge 260d1d2...

@bors-servo bors-servo added a commit that referenced this pull request Oct 4, 2016
@bors-servo bors-servo Auto merge of #13570 - Wafflespeanut:font_stretch, r=Manishearth
Add support for 'font-stretch' in geckolib

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13570)
<!-- Reviewable:end -->
260d1d2
@bors-servo
Contributor

💔 Test failed - mac-rel-wpt2

@Manishearth
Member
Manishearth commented Oct 4, 2016 edited
@bors-servo
Contributor

⌛️ Testing commit 361f372 with merge b772f43...

@bors-servo bors-servo added a commit that referenced this pull request Oct 4, 2016
@bors-servo bors-servo Auto merge of #13570 - Wafflespeanut:font_stretch, r=Manishearth
Add support for 'font-stretch' in geckolib

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13570)
<!-- Reviewable:end -->
b772f43
@bors-servo bors-servo referenced this pull request Oct 4, 2016
Merged

Use parking_lot::RwLock for PropertyDeclarationBlock #13459

3 of 5 tasks complete
@bors-servo bors-servo merged commit 361f372 into servo:master Oct 4, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Wafflespeanut Wafflespeanut deleted the Wafflespeanut:font_stretch branch Oct 5, 2016
@joewalker joewalker referenced this pull request Oct 13, 2016
Merged

Add support for 'font-kerning' in geckolib #13751

1 of 1 task complete
@bors-servo bors-servo added a commit that referenced this pull request Oct 14, 2016
@bors-servo bors-servo Auto merge of #13751 - joewalker:font-kerning, r=Manishearth
Add support for 'font-kerning' in geckolib

Add support for 'font-kerning' in geckolib
These changes fix #13667

    $ ./mach build -d
    It looks like you passed an unrecognized argument into mach.

    $ ./mach test-tidy
    It looks like you are trying to run an unknown mach command: test-tidy

I'm clearly doing something wrong here, but I'm not sure what

- [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](#13570 (comment))" :)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13751)
<!-- Reviewable:end -->
b94f074
@moz-v2v-gh moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 4, 2017
@joewalker joewalker servo: Merge #13751 - Add support for 'font-kerning' in geckolib (fro…
…m joewalker:font-kerning); r=Manishearth

Add support for 'font-kerning' in geckolib
These changes fix #13667

    $ ./mach build -d
    It looks like you passed an unrecognized argument into mach.

    $ ./mach test-tidy
    It looks like you are trying to run an unknown mach command: test-tidy

I'm clearly doing something wrong here, but I'm not sure what

- [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](servo/servo#13570 (comment))" :)

Source-Repo: https://github.com/servo/servo
Source-Revision: b94f074b52584f467c61ee5d1851b1b4557ccfcb
bccbbc2
@xeonchen xeonchen pushed a commit to mozilla-necko/gecko that referenced this pull request Feb 4, 2017
@joewalker joewalker servo: Merge #13751 - Add support for 'font-kerning' in geckolib (fro…
…m joewalker:font-kerning); r=Manishearth

Add support for 'font-kerning' in geckolib
These changes fix #13667

    $ ./mach build -d
    It looks like you passed an unrecognized argument into mach.

    $ ./mach test-tidy
    It looks like you are trying to run an unknown mach command: test-tidy

I'm clearly doing something wrong here, but I'm not sure what

- [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](servo/servo#13570 (comment))" :)

Source-Repo: https://github.com/servo/servo
Source-Revision: b94f074b52584f467c61ee5d1851b1b4557ccfcb
f3c8a7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment