Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify fetching code. #13571

Merged
merged 6 commits into from Oct 4, 2016
Merged

Simplify fetching code. #13571

merged 6 commits into from Oct 4, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 4, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 6 commits Oct 4, 2016
@Ms2ger
Avoid PendingAsyncLoad in fetch_async.
5968947
@Ms2ger
Remove unused Document::prepare_async_load.
8d01baa
@Ms2ger
Inline prepare_async_load.
e4c0007
@Ms2ger
Remove Document::add_blocking_load.
aa48ec7
@Ms2ger
Privatize PendingAsyncLoad.
1a2db0b
@Ms2ger
Refactor away PendingAsyncLoad.
Loading status checks…
86fdab2
@highfive
Copy link

highfive commented Oct 4, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmlscriptelement.rs, components/script/dom/document.rs, components/script/document_loader.rs, components/net_traits/lib.rs, components/net_traits/lib.rs
@highfive
Copy link

highfive commented Oct 4, 2016

warning Warning warning

  • These commits modify gfx and script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 4, 2016

First commit got in my way for #13462; the rest is what happens if you keep pulling on a loose thread.

r? @jdm
@highfive highfive assigned jdm and unassigned KiChjang Oct 4, 2016
@nox
Copy link
Member

nox commented Oct 4, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2016

📌 Commit 86fdab2 has been approved by nox
@highfive highfive assigned nox and unassigned jdm Oct 4, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2016

⌛ Testing commit 86fdab2 with merge b80769d...
bors-servo added a commit that referenced this pull request Oct 4, 2016
@bors-servo
Auto merge of #13571 - servo:simplify-fetching, r=nox
Loading status checks…
b80769d 
Simplify fetching code.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13571)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 86fdab2 into master Oct 4, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
dependency-ci Failed dependency checks
Details
homu Test successful
Details
@jdm
jdm reviewed Oct 4, 2016
View changes
components/net_traits/lib.rs
@@ -467,35 +466,13 @@ pub enum CoreResourceMsg {
/// Initialized but unsent request. Encapsulates everything necessary to instruct
/// the resource thread to make a new request. The `load` method *must* be called before
/// destruction or the thread will panic.

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Oct 4, 2016

Member

This comment no longer applies.
@Ms2ger Ms2ger deleted the simplify-fetching branch Oct 4, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
31 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @nox @bors-servo @jdm @KiChjang
You can’t perform that action at this time.