Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some global things #13572

Merged
merged 3 commits into from Oct 4, 2016
Merged

Clean up some global things #13572

merged 3 commits into from Oct 4, 2016

Conversation

@nox
Copy link
Member

nox commented Oct 4, 2016 •
edited by larsbergstrom

This change is Reviewable
nox added 3 commits Oct 1, 2016
@nox
Remove GlobalRef::get_worker_id
e2dfcb6
@nox
Simplify GlobalRef::resource_threads
1aebe9f
@nox
Remove ScopeThings::pipeline_id
Loading status checks…
d02a615 
It can be retrieved through its init field.
@highfive
Copy link

highfive commented Oct 4, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/global.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/dom/console.rs, components/script/serviceworker_manager.rs, components/script/dom/serviceworkerregistration.rs
@highfive
Copy link

highfive commented Oct 4, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Oct 4, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2016

📌 Commit d02a615 has been approved by jdm
@highfive highfive assigned jdm and unassigned larsbergstrom Oct 4, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2016

⌛ Testing commit d02a615 with merge 8956f62...
bors-servo added a commit that referenced this pull request Oct 4, 2016
@bors-servo
Auto merge of #13572 - nox:cleanup-global, r=jdm
Loading status checks…
8956f62 
Clean up some global things

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13572)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Oct 4, 2016 

  ▶ Unexpected subtest result in /html/webappapis/scripting/event-loops/microtask_after_raf.html:
  └ PASS [expected FAIL] Microtask execute immediately after script
@jdm
Copy link
Member

jdm commented Oct 4, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2016

⌛ Testing commit d02a615 with merge 136c9a8...
bors-servo added a commit that referenced this pull request Oct 4, 2016
@bors-servo
Auto merge of #13572 - nox:cleanup-global, r=jdm
Loading status checks…
136c9a8 
Clean up some global things

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13572)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit d02a615 into servo:master Oct 4, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @larsbergstrom
You can’t perform that action at this time.