Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse the fetch stack for stylesheets. #13575
Conversation
highfive
commented
Oct 4, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 4, 2016
|
|
| pipeline_id: Some(self.global().r().pipeline_id()), | ||
| referrer_url: Some(document.url().clone()), | ||
| referrer_policy: referrer_policy, | ||
| .. RequestInit::default() |
This comment has been minimized.
This comment has been minimized.
jdm
Oct 4, 2016
•
Member
This should set use_url_credentials to true per https://html.spec.whatwg.org/multipage/infrastructure.html#create-a-potential-cors-request , as well as set mode to Cors.
| let request = RequestInit { | ||
| url: url.clone(), | ||
| type_: RequestType::Script, | ||
| destination: Destination::Style, |
This comment has been minimized.
This comment has been minimized.
jdm
Oct 4, 2016
•
Member
The spec says destination should be the empty string, but the table at https://fetch.spec.whatwg.org/#concept-request-type disagrees. I've filed whatwg/html#1856.
|
|
||
| let request = RequestInit { | ||
| url: url.clone(), | ||
| type_: RequestType::Script, |
This comment has been minimized.
This comment has been minimized.
jdm
Oct 4, 2016
•
Member
The spec doesn't specify a type; the table at https://fetch.spec.whatwg.org/#concept-request-type says it should be style.
|
Done |
|
@bors-servo: r+ |
|
|
Use the fetch stack for stylesheets. Fixes #13462. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13575) <!-- Reviewable:end -->
|
|
Ms2ger commentedOct 4, 2016
•
edited by larsbergstrom
Fixes #13462.
This change is