Provide the fetched data to fetch() consumers. #13597

Ms2ger · 2016-10-05T13:28:12Z

This change is

highfive · 2016-10-05T13:28:16Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/request.rs, components/script/fetch.rs, components/script/dom/response.rs, components/script/body.rs

Ms2ger · 2016-10-05T13:28:20Z

@bors-servo try

bors-servo · 2016-10-05T13:28:22Z

⌛ Trying commit 7ac1910 with merge e447d56...


        Auto merge of #13597 - servo:fetch, r=<try>

Provide the fetched data to fetch() consumers.

jdm · 2016-10-05T13:44:12Z

components/script/dom/request.rs

@@ -662,20 +665,19 @@ impl BodyOperations for Request {
        self.BodyUsed()
    }

+    fn set_body_promise(&self, p: &Rc<Promise>, body_type: BodyType) {
+        self.body_used.set(true);
+        assert!(mem::replace(&mut *self.body_promise.borrow_mut(), Some((p.clone(), body_type))).is_none());


Same as later comment.

jdm · 2016-10-05T13:44:12Z

components/script/dom/response.rs

@@ -194,18 +197,25 @@ impl BodyOperations for Response {
        self.BodyUsed()
    }

+    fn set_body_promise(&self, p: &Rc<Promise>, body_type: BodyType) {
+        self.body_used.set(true);
+        assert!(mem::replace(&mut *self.body_promise.borrow_mut(), Some((p.clone(), body_type))).is_none());


This is a complicated way of writing

assert!(self.body_promise.borrow().is_none()); *self.body_promise.borrow_mut() = Some(p.clone(), body_type);

which I would prefer.

jdm · 2016-10-05T13:44:12Z

components/script/body.rs

+}
+
+// https://fetch.spec.whatwg.org/#concept-body-consume-body
+#[allow(unrooted_must_root)]


Is this necessary?

jdm · 2016-10-05T13:44:12Z

components/script/body.rs

-            };
-        },
-        Err(err) => promise.reject_error(cx, err),
+    if let Some(body) = object.take_body() {


let body = match object.take_body() { Some(body) => body, None => return, };

bors-servo · 2016-10-05T14:00:34Z

💔 Test failed - mac-rel-wpt1

Ms2ger · 2016-10-05T14:37:37Z

@bors-servo try

bors-servo · 2016-10-05T14:37:39Z

⌛ Trying commit c805e3b with merge 1a28907...


        Auto merge of #13597 - servo:fetch, r=<try>

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-05T15:09:44Z

💔 Test failed - linux-rel-wpt

jdm · 2016-10-05T15:14:03Z

We probably need a compartment for the JSON case.

Ms2ger · 2016-10-06T10:00:13Z

@bors-servo try

bors-servo · 2016-10-06T10:00:16Z

⌛ Trying commit 8f6a0b7 with merge 3ca06c1...


        Auto merge of #13597 - servo:fetch, r=<try>

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-06T10:32:27Z

💔 Test failed - mac-rel-wpt1


        Provide the fetched data to fetch() consumers.


        Enable some referrer-policy tests now that they no longer time out.

bors-servo · 2016-10-06T13:57:55Z

⌛ Testing commit cd47e21 with merge 113ef4c...


        Auto merge of #13597 - servo:fetch, r=jdm

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-06T14:46:23Z

💔 Test failed - mac-rel-css

Ms2ger · 2016-10-06T15:00:58Z

@bors-servo retry

bors-servo · 2016-10-06T15:25:25Z

⌛ Testing commit cd47e21 with merge 0d25bc9...


        Auto merge of #13597 - servo:fetch, r=jdm

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

larsbergstrom · 2016-10-06T15:50:51Z

@bors-servo clean force retry

infra buildbot restart

bors-servo · 2016-10-06T15:56:31Z

⌛ Testing commit cd47e21 with merge f1c3288...


        Auto merge of #13597 - servo:fetch, r=jdm

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-06T16:13:40Z

💔 Test failed - linux-dev

Ms2ger · 2016-10-06T16:17:36Z

Oh what the hell:

LLVM ERROR: IO failure on output stream.

twice on servo-linux2

@larsbergstrom ?

larsbergstrom · 2016-10-06T16:24:10Z

@Ms2ger disk full, please retry.

larsbergstrom · 2016-10-06T16:30:36Z

@bors-servo retry

infra

bors-servo · 2016-10-06T17:34:02Z

⌛ Testing commit cd47e21 with merge bd05aa2...


        Auto merge of #13597 - servo:fetch, r=jdm

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-06T18:27:25Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

highfive assigned glennw Oct 5, 2016

highfive added the S-awaiting-review label Oct 5, 2016

bors-servo added a commit that referenced this pull request Oct 5, 2016

Auto merge of #13597 - servo:fetch, r=<try>

Loading status checks…

e447d56

Provide the fetched data to fetch() consumers.

jdm requested changes Oct 5, 2016

View changes

jdm assigned jdm and unassigned glennw Oct 5, 2016

jdm added S-needs-code-changes and removed S-awaiting-review labels Oct 5, 2016

highfive added S-tests-failed S-awaiting-review and removed S-tests-failed S-needs-code-changes labels Oct 5, 2016

highfive added the S-tests-failed label Oct 5, 2016

highfive removed the S-tests-failed label Oct 6, 2016

highfive added the S-tests-failed label Oct 6, 2016

Ms2ger added 2 commits Oct 5, 2016

Provide the fetched data to fetch() consumers.

cb7e671

Enable some referrer-policy tests now that they no longer time out.

Loading status checks…

cd47e21

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 6, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Oct 6, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 6, 2016

larsbergstrom mentioned this pull request Oct 6, 2016

Need to periodically clean up buildbot slave directories servo/saltfs#506

Open

highfive added S-awaiting-merge and removed S-tests-failed labels Oct 6, 2016

highfive removed the S-awaiting-merge label Oct 6, 2016

bors-servo mentioned this pull request Oct 6, 2016

Get rid of dom::bindings::global #13596

Merged

SimonSapin deleted the fetch branch Nov 3, 2016

Ms2ger mentioned this pull request Nov 7, 2016

Remove the legacy networking stack #14115

Closed

31 of 31 tasks complete

servo / servo

Provide the fetched data to fetch() consumers. #13597

Provide the fetched data to fetch() consumers. #13597

Ms2ger commented Oct 5, 2016 •

edited by larsbergstrom

highfive commented Oct 5, 2016

Ms2ger commented Oct 5, 2016

bors-servo commented Oct 5, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors-servo commented Oct 5, 2016

Ms2ger commented Oct 5, 2016

bors-servo commented Oct 5, 2016

bors-servo commented Oct 5, 2016

jdm commented Oct 5, 2016

Ms2ger commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 6, 2016

bors-servo commented Oct 6, 2016

larsbergstrom commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 6, 2016

larsbergstrom commented Oct 6, 2016

larsbergstrom commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

servo / servo

Join GitHub today

Provide the fetched data to fetch() consumers. #13597

Provide the fetched data to fetch() consumers. #13597

Conversation

Ms2ger commented Oct 5, 2016 • edited by larsbergstrom

highfive commented Oct 5, 2016

Ms2ger commented Oct 5, 2016

bors-servo commented Oct 5, 2016

This comment has been minimized.

jdm Oct 5, 2016

This comment has been minimized.

jdm Oct 5, 2016

This comment has been minimized.

jdm Oct 5, 2016

This comment has been minimized.

Ms2ger Oct 6, 2016

This comment has been minimized.

jdm Oct 5, 2016

bors-servo commented Oct 5, 2016

Ms2ger commented Oct 5, 2016

bors-servo commented Oct 5, 2016

bors-servo commented Oct 5, 2016

jdm commented Oct 5, 2016

Ms2ger commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 6, 2016

bors-servo commented Oct 6, 2016

larsbergstrom commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 6, 2016

larsbergstrom commented Oct 6, 2016

larsbergstrom commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 5, 2016 •

edited by larsbergstrom