Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that SERVO_ENABLE_DEBUG_ASSERTIONS is also used in build-cef #13601

Merged
merged 1 commit into from Oct 5, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Ensure that SERVO_ENABLE_DEBUG_ASSERTIONS is also used in build-cef

  • Loading branch information
larsbergstrom committed Oct 5, 2016
commit e16c7ec861e75a541972cb9c72b067f1badcdf9d
@@ -324,9 +324,18 @@ def build_cef(self, jobs=None, verbose=False, release=False):
opts += ["--features", "%s" % ' '.join("servo/" + x for x in servo_features)]

build_start = time()
env = self.build_env(is_build=True)

# TODO: If this ends up making it, we should probably add a
# --release-with-debug-assertions option or similar, so it's easier to
# build locally.
if env.get("SERVO_ENABLE_DEBUG_ASSERTIONS", None):
env["RUSTFLAGS"] = "-C debug_assertions"

with cd(path.join("ports", "cef")):
ret = call(["cargo", "build"] + opts,
env=self.build_env(is_build=True), verbose=verbose)
env=env,
verbose=verbose)
elapsed = time() - build_start

# Generate Desktop Notification if elapsed-time > some threshold value
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.