Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync Buildbot steps config from saltfs #13611
Merged
Conversation
Now that our Buildbot configuration is successfully able to read the steps configuration from the main servo repo and run builds, sync the steps in the servo tree to match the latest steps.yml from the saltfs repo.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 6, 2016
Sync Buildbot steps config from saltfs <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes are part of servo/saltfs#316 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they just copy the steps configuration <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Now that our Buildbot configuration is successfully able to read the steps configuration from the main servo repo and run builds, sync the steps in the servo tree to match the latest steps.yml from the saltfs repo. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13611) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
to servo/saltfs
that referenced
this pull request
Oct 19, 2016
…rsbergstrom Remove old DynamicServoFactory which reads from saltfs Now that the new dynamic factory is working (which reads the steps configuration from the main servo repo), remove the old one. However, re-use the old name (DynamicServoFactory instead of DynamicServoYAMLFactory) for concision and clarity. Fixes #316. Blocked on servo/servo#13611. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/504) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedOct 6, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsNow that our Buildbot configuration is successfully able to read the
steps configuration from the main servo repo and run builds, sync the
steps in the servo tree to match the latest steps.yml from the saltfs
repo.
This change is