Upgrade wptrunner #13614

jdm · 2016-10-06T12:11:42Z

This gets us back to a pristine local copy and allows us to start experimenting with webdriver tests.

This change is


        Rename mach command to upgrade wptrunner and make it work more than o…

…nce.


        Avoid #12321 by creating environment before switching directories.

highfive · 2016-10-06T12:11:46Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/devenv_commands.py
@jgraham: tests/wpt/harness/wptrunner/wpttest.py, tests/wpt/harness/wptrunner/wptmanifest/tests/test_serializer.py, tests/wpt/harness/wptrunner/wptmanifest/parser.py, tests/wpt/harness/wptrunner/browsers/servo.py, tests/wpt/harness/wptrunner/webdriver_server.py, tests/wpt/harness/wptrunner/wptcommandline.py, tests/wpt/harness/wptrunner/tests/test_chunker.py, tests/wpt/harness/wptrunner/executors/pytestrunner/fixtures.py, tests/wpt/harness/wptrunner/executors/executorservo.py, tests/wpt/harness/wptrunner/wptrunner.py, tests/wpt/harness/wptrunner/browsers/firefox.py, tests/wpt/harness/wptrunner/browsers/init.py, tests/wpt/harness/wptrunner/tests/test_update.py, tests/wpt/harness/wptrunner/testloader.py, tests/wpt/harness/wptrunner/executors/executorservodriver.py, tests/wpt/harness/wptrunner/executors/executormarionette.py, tests/wpt/harness/wptrunner/executors/executorselenium.py, tests/wpt/harness/wptrunner/executors/testharness_webdriver.js, tests/wpt/harness/wptrunner/executors/pytestrunner/runner.py, tests/wpt/harness/wptrunner/testrunner.py, tests/wpt/harness/wptrunner/tests/test_hosts.py

jdm · 2016-10-06T12:12:18Z

@bors-servo: try

bors-servo · 2016-10-06T12:12:21Z

⌛ Trying commit 5c5fd8f with merge a2d554b...


        Auto merge of #13614 - jdm:wptrunnerup3, r=<try>

Upgrade wptrunner This gets us back to a pristine local copy and allows us to start experimenting with webdriver tests.

Ms2ger · 2016-10-06T12:14:23Z

@bors-servo try- r+

bors-servo · 2016-10-06T12:14:24Z

📌 Commit 5c5fd8f has been approved by Ms2ger

Ms2ger · 2016-10-06T13:21:15Z

@bors-servo r+

bors-servo · 2016-10-06T13:21:15Z

📌 Commit 64ac008 has been approved by Ms2ger

bors-servo · 2016-10-06T21:02:08Z

⌛ Testing commit 64ac008 with merge a578442...


        Auto merge of #13614 - jdm:wptrunnerup3, r=Ms2ger

Upgrade wptrunner This gets us back to a pristine local copy and allows us to start experimenting with webdriver tests.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13614)

bors-servo · 2016-10-06T21:19:47Z

💔 Test failed - mac-rel-wpt2

jdm · 2016-10-06T21:45:08Z

cc @jgraham for the previous failure:

STDERR: /Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py:161: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  if c == "\\":
STDERR: /Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py:163: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  elif c == "]":
Error running mach:

    ['test-wpt', '--release', '--processes', '8', '--total-chunks', '2', '--this-chunk', '2', '--log-raw', 'test-wpt.log', '--log-errorsummary', 'wpt-errorsummary.log']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xce in position 0: ordinal not in range(128)

  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/python/servo/testing_commands.py", line 396, in test_wpt
    return self.run_test_list_or_dispatch(kwargs["test_list"], "wpt", self._test_wpt, **kwargs)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/python/servo/testing_commands.py", line 407, in run_test_list_or_dispatch
    return correct_function(**kwargs)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/python/servo/testing_commands.py", line 402, in _test_wpt
    return self.wptrunner(run_file, **kwargs)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/python/servo/testing_commands.py", line 466, in wptrunner
    return run_globals["run_tests"](**kwargs)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/run_wpt.py", line 13, in run_tests
    return run.run_tests(paths=paths, **kwargs)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/run.py", line 36, in run_tests
    success = wptrunner.run_tests(**kwargs)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptrunner.py", line 135, in run_tests
    **kwargs)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptrunner.py", line 71, in get_loader
    include_https=ssl_env.ssl_enabled)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/testloader.py", line 460, in __init__
    self._load_tests()
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/testloader.py", line 526, in _load_tests
    for test_path, test_type, test in self.iter_tests():
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/testloader.py", line 511, in iter_tests
    inherit_metadata, test_metadata = self.load_metadata(manifest_file, metadata_path, test_path)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/testloader.py", line 494, in load_metadata
    metadata_path, test_path, test_manifest.url_base, self.run_info)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/manifestexpected.py", line 236, in get_manifest
    url_base=url_base)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/backends/static.py", line 221, in compile
    return compile_ast(parse(stream),
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py", line 747, in parse
    return p.parse(stream)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py", line 511, in parse
    self.manifest()
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py", line 527, in manifest
    self.data_block()
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py", line 547, in data_block
    self.data_block()
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py", line 539, in data_block
    self.consume()
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py", line 515, in consume
    self.token = self.token_generator.next()
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py", line 102, in tokenize
    for token in tokens:
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/wptmanifest/parser.py", line 168, in heading_state
    rv += c
program finished with exit code 1

I couldn't reproduce it locally.

jgraham · 2016-10-06T21:58:31Z

Try reverting 496353104e7ee0969e316c12caf3dc2988efb8e8 in the wptrunner repo (just a guess).

jdm · 2016-10-07T04:59:31Z

@bors-servo: try

bors-servo · 2016-10-07T04:59:33Z

⌛ Trying commit 412ea87 with merge 9de56c4...


        Auto merge of #13614 - jdm:wptrunnerup3, r=<try>

Upgrade wptrunner This gets us back to a pristine local copy and allows us to start experimenting with webdriver tests.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13614)

bors-servo · 2016-10-07T05:58:33Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

jdm · 2016-10-07T13:01:27Z

@jgraham reverting that commit did the trick.

jgraham · 2016-10-07T13:12:10Z

@Ms2ger: apparently things are never simple :(

Ms2ger · 2016-10-18T12:49:11Z

So it clearly is.

@bors-servo r+

bors-servo · 2016-10-18T12:49:12Z

📌 Commit 412ea87 has been approved by Ms2ger

Ms2ger · 2016-10-18T12:50:49Z

I'll try to figure out what's wrong after this lands.

jdm · 2016-10-18T13:11:03Z

@bors-servo: r-
A couple files are missing.


        Upgrade wptrunner to 83fb6b727817a7dfeb24763d099aca95bc674b8e.


        Revert wptrunner 496353104e7ee0969e316c12caf3dc2988efb8e8

jdm · 2016-10-18T13:15:09Z

@bors-servo: r=Ms2ger

bors-servo · 2016-10-18T13:15:10Z

📌 Commit a9c2dda has been approved by Ms2ger

bors-servo · 2016-10-18T13:15:12Z

⌛ Testing commit a9c2dda with merge 80447a7...


        Auto merge of #13614 - jdm:wptrunnerup3, r=Ms2ger

Upgrade wptrunner This gets us back to a pristine local copy and allows us to start experimenting with webdriver tests.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13614)

bors-servo · 2016-10-18T14:03:20Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

Ms2ger · 2016-10-18T16:03:43Z

w3c/wptrunner#216 fixes the error seen here.

jdm added 2 commits Jul 4, 2016

Rename mach command to upgrade wptrunner and make it work more than o…

906b7b3

…nce.

Avoid #12321 by creating environment before switching directories.

a2bc9d7

highfive assigned Manishearth Oct 6, 2016

highfive added the S-awaiting-review label Oct 6, 2016

bors-servo added a commit that referenced this pull request Oct 6, 2016

Auto merge of #13614 - jdm:wptrunnerup3, r=<try>

Loading status checks…

a2d554b

Upgrade wptrunner This gets us back to a pristine local copy and allows us to start experimenting with webdriver tests.

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 6, 2016

highfive assigned Ms2ger and unassigned Manishearth Oct 6, 2016

Ms2ger closed this Oct 6, 2016

Ms2ger reopened this Oct 6, 2016

Ms2ger force-pushed the jdm:wptrunnerup3 branch from 5c5fd8f to 64ac008 Oct 6, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Oct 6, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 6, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 6, 2016

highfive added the S-awaiting-review label Oct 7, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 18, 2016

jdm added 2 commits Oct 3, 2016

Upgrade wptrunner to 83fb6b727817a7dfeb24763d099aca95bc674b8e.

d6318c8

Revert wptrunner 496353104e7ee0969e316c12caf3dc2988efb8e8

Loading status checks…

a9c2dda

jdm force-pushed the jdm:wptrunnerup3 branch from 412ea87 to a9c2dda Oct 18, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Oct 18, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 18, 2016

bors-servo merged commit a9c2dda into servo:master Oct 18, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Oct 18, 2016

bors-servo mentioned this pull request Oct 18, 2016

Start running webdriver tests #13261

Closed

3 of 3 tasks complete

Ms2ger deleted the jdm:wptrunnerup3 branch Oct 18, 2016

servo / servo

Upgrade wptrunner #13614

Upgrade wptrunner #13614

jdm commented Oct 6, 2016 •

edited by larsbergstrom

highfive commented Oct 6, 2016

jdm commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

jdm commented Oct 6, 2016

jgraham commented Oct 6, 2016

jdm commented Oct 7, 2016

bors-servo commented Oct 7, 2016

bors-servo commented Oct 7, 2016

jdm commented Oct 7, 2016

jgraham commented Oct 7, 2016

Ms2ger commented Oct 18, 2016

bors-servo commented Oct 18, 2016

Ms2ger commented Oct 18, 2016

jdm commented Oct 18, 2016

jdm commented Oct 18, 2016

bors-servo commented Oct 18, 2016

bors-servo commented Oct 18, 2016

bors-servo commented Oct 18, 2016

Ms2ger commented Oct 18, 2016

servo / servo

Join GitHub today

Upgrade wptrunner #13614

Upgrade wptrunner #13614

Conversation

jdm commented Oct 6, 2016 • edited by larsbergstrom

highfive commented Oct 6, 2016

jdm commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 6, 2016

bors-servo commented Oct 6, 2016

Ms2ger commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

bors-servo commented Oct 6, 2016

jdm commented Oct 6, 2016

jgraham commented Oct 6, 2016

jdm commented Oct 7, 2016

bors-servo commented Oct 7, 2016

bors-servo commented Oct 7, 2016

jdm commented Oct 7, 2016

jgraham commented Oct 7, 2016

Ms2ger commented Oct 18, 2016

bors-servo commented Oct 18, 2016

Ms2ger commented Oct 18, 2016

jdm commented Oct 18, 2016

jdm commented Oct 18, 2016

bors-servo commented Oct 18, 2016

bors-servo commented Oct 18, 2016

bors-servo commented Oct 18, 2016

Ms2ger commented Oct 18, 2016

jdm commented Oct 6, 2016 •

edited by larsbergstrom