webgl: Enable all the tests on linux #13629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that testing is being done using OSMesa on the Linux side as well, our test behavior matches Mac's pretty closely.
|
@bors-servo: r+
|
|
📌 Commit 19a8a4c has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Oct 7, 2016
webgl: Enable all the tests on linux <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Now that testing is being done using OSMesa on the Linux side as well, our test behavior matches Mac's pretty closely. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13629) <!-- Reviewable:end -->
|
Oh, @emilio beat me to it! :) |
|
I haven't marked ./mach build -d as passing because it's failing for me in mozjs: However, it's also failing without this patch. ./mach build -r is succeeding. |
This was referenced Oct 7, 2016
|
@bors-servo: try- clean r=emilio |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 19a8a4c has been approved by |
|
@bors-servo force clean retry |
bors-servo
pushed a commit
that referenced
this pull request
Oct 7, 2016
webgl: Enable all the tests on linux <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Now that testing is being done using OSMesa on the Linux side as well, our test behavior matches Mac's pretty closely. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13629) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsNow that testing is being done using OSMesa on the Linux side as well,
our test behavior matches Mac's pretty closely.
This change is