Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upwebgl: Enable all the tests on linux #13629
Merged
+8
−10
Conversation
Now that testing is being done using OSMesa on the Linux side as well, our test behavior matches Mac's pretty closely.
|
@bors-servo: r+
|
|
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 7, 2016
webgl: Enable all the tests on linux <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Now that testing is being done using OSMesa on the Linux side as well, our test behavior matches Mac's pretty closely. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13629) <!-- Reviewable:end -->
|
Oh, @emilio beat me to it! :) |
|
I haven't marked ./mach build -d as passing because it's failing for me in mozjs: However, it's also failing without this patch. ./mach build -r is succeeding. |
This was referenced Oct 7, 2016
|
@bors-servo: try- clean r=emilio |
|
|
|
|
@bors-servo force clean retry |
bors-servo
added a commit
that referenced
this pull request
Oct 7, 2016
webgl: Enable all the tests on linux <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Now that testing is being done using OSMesa on the Linux side as well, our test behavior matches Mac's pretty closely. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13629) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
anholt commentedOct 7, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsNow that testing is being done using OSMesa on the Linux side as well,
our test behavior matches Mac's pretty closely.
This change is