Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSend touch events to root pipeline, and allow forwarding to iframes. #13633
Conversation
highfive
commented
Oct 7, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 7, 2016
|
r? @mbrubeck This contains the event forwarding for touch events we discussed on IRC. See #8811 for details. I've tested this on my (Linux) touchscreen laptop and as far as I can tell it's all working as previously. I've tested touch events, and touch scrolling on normal pages, and also within iframes (via browser.html). |
|
|
|
-S-awaiting-review +S-needs-code-changes r=mbrubeck with a minor nit fixed: Reviewed 4 of 5 files at r1. components/compositing/compositor.rs, line 1534 at r1 (raw file):
Nit: components/compositing/compositor.rs, line 1561 at r1 (raw file):
components/compositing/compositor.rs, line 1572 at r1 (raw file):
components/compositing/compositor.rs, line 1585 at r1 (raw file):
components/compositing/compositor.rs, line 1595 at r1 (raw file):
Comments from Reviewable |
Instead of letting the compositor try to find the correct scroll layer for a touch event, switch touch events to work the same way that mouse events do. Touch events are now dispatched to the root pipeline, and then forwarded to child iframes as required.
|
Addressed comments and rebased. |
|
@bors-servo r+ Reviewed 1 of 5 files at r1, 3 of 3 files at r2. Comments from Reviewable |
|
|
Send touch events to root pipeline, and allow forwarding to iframes. Instead of letting the compositor try to find the correct scroll layer for a touch event, switch touch events to work the same way that mouse events do. Touch events are now dispatched to the root pipeline, and then forwarded to child iframes as required. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13633) <!-- Reviewable:end -->
|
|
glennw commentedOct 7, 2016
•
edited by larsbergstrom
Instead of letting the compositor try to find the correct scroll
layer for a touch event, switch touch events to work the same way
that mouse events do.
Touch events are now dispatched to the root pipeline, and then
forwarded to child iframes as required.
This change is