Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URLSearchParams iterable. #13637

Merged
merged 1 commit into from Oct 7, 2016
Merged

Make URLSearchParams iterable. #13637

merged 1 commit into from Oct 7, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 7, 2016 •
edited by larsbergstrom

Fixes #13022.
Fixes #13077.

This change is Reviewable
@yoyo930021 @Ms2ger
Make URLSearchParams iterable.
Loading status checks…
980c644 
Fixes #13022.
Fixes #13077.
@highfive
Copy link

highfive commented Oct 7, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/URLSearchParams.webidl, components/script/dom/urlsearchparams.rs
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 7, 2016

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2016

📌 Commit 980c644 has been approved by emilio
@highfive highfive assigned emilio and unassigned cbrewster Oct 7, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2016

⌛ Testing commit 980c644 with merge b1c5b91...
bors-servo added a commit that referenced this pull request Oct 7, 2016
@bors-servo
Auto merge of #13637 - servo:URLSearchParams, r=emilio
Loading status checks…
b1c5b91 
Make URLSearchParams iterable.

Fixes #13022.
Fixes #13077.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13637)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2016

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Oct 7, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 980c644 into master Oct 7, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
dependency-ci Failed dependency checks
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the URLSearchParams branch Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Ms2ger @highfive @bors-servo @jdm @emilio @cbrewster @yoyo930021
You can’t perform that action at this time.