Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some of the CSSStyleDeclaration logic to the style crate #13640

Merged
merged 5 commits into from Oct 12, 2016
Merged

Move some of the CSSStyleDeclaration logic to the style crate #13640

merged 5 commits into from Oct 12, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Oct 7, 2016 •
edited by larsbergstrom

… so that Stylo can re-use it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295865

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because refator

This change is Reviewable
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 7, 2016

r? @mbrubeck
@emilio
Copy link
Member

emilio commented Oct 10, 2016

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

⌛ Trying commit 704fdf9 with merge b7095df...
bors-servo added a commit that referenced this pull request Oct 10, 2016
@bors-servo
Auto merge of #13640 - servo:CSSStyleDeclaration_in_style, r=<try>
Loading status checks…
b7095df 
Move some of the CSSStyleDeclaration logic to the style crate

<!-- Please describe your changes on the following line: -->

… so that Stylo can re-use it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295865

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refator

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13640)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

💔 Test failed - linux-rel-wpt
@emilio
Copy link
Member

emilio commented Oct 10, 2016 

▶ CRASH [expected PASS] /_mozilla/css/removeproperty.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 12.0.1
  │ DOMRefCell<T> already mutably borrowed: BorrowError (thread ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(1) }, at ../src/libcore/result.rs:799)
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 10, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

⌛ Trying commit e0360c0 with merge 81a888b...
bors-servo added a commit that referenced this pull request Oct 10, 2016
@bors-servo
Auto merge of #13640 - servo:CSSStyleDeclaration_in_style, r=<try>
Loading status checks…
81a888b 
Move some of the CSSStyleDeclaration logic to the style crate

<!-- Please describe your changes on the following line: -->

… so that Stylo can re-use it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295865

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refator

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13640)
<!-- Reviewable:end -->
SimonSapin added 5 commits Oct 7, 2016
@SimonSapin
Move CSSStyleDeclaration.GetPropertyValue logic to style
bd37f4e
@SimonSapin
Move CSSStyleDeclaration.GetPropertyPriority logic to style
fc6a536
@SimonSapin
Move CSSStyleDeclaration.RemoveProperty logic to style
bd4a4c3
@SimonSapin
Move (some) CSSStyleDeclaration.SetProperty logic to style
c740a76
@SimonSapin
Move CSSStyleDeclaration.SetPropertyPriority logic to style
Loading status checks…
0eed39c
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@SimonSapin SimonSapin force-pushed the CSSStyleDeclaration_in_style branch from e0360c0 to 0eed39c Oct 10, 2016
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 10, 2016

@bors-servo try
bors-servo added a commit that referenced this pull request Oct 10, 2016
@bors-servo
Auto merge of #13640 - servo:CSSStyleDeclaration_in_style, r=<try>
Loading status checks…
481a570 
Move some of the CSSStyleDeclaration logic to the style crate

<!-- Please describe your changes on the following line: -->

… so that Stylo can re-use it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295865

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refator

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13640)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

⌛ Trying commit 0eed39c with merge 481a570...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 10, 2016

@bors-servo r+

Reviewed 3 of 3 files at r1, 3 of 3 files at r2, 3 of 3 files at r3, 4 of 4 files at r4, 3 of 3 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

📌 Commit 0eed39c has been approved by mbrubeck
@Manishearth
Copy link
Member

Manishearth commented Oct 12, 2016

@bors-servo try- retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

⌛ Testing commit 0eed39c with merge 40a6501...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

💔 Test failed - mac-rel-wpt2
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 12, 2016 •
edited by jdm

@bors-servo retry

#13133
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 12, 2016 •
edited

IRC

Manishearth> SimonSapin: it's not infra, it's an IPC issue iirc
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

⌛ Testing commit 0eed39c with merge 000d15f...
bors-servo added a commit that referenced this pull request Oct 12, 2016
@bors-servo
Auto merge of #13640 - servo:CSSStyleDeclaration_in_style, r=mbrubeck
Loading status checks…
000d15f 
Move some of the CSSStyleDeclaration logic to the style crate

<!-- Please describe your changes on the following line: -->

… so that Stylo can re-use it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295865

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refator

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13640)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Oct 12, 2016

@bors-servo: retry
bors-servo added a commit that referenced this pull request Oct 12, 2016
@bors-servo
Auto merge of #13640 - servo:CSSStyleDeclaration_in_style, r=mbrubeck
Loading status checks…
9224938 
Move some of the CSSStyleDeclaration logic to the style crate

<!-- Please describe your changes on the following line: -->

… so that Stylo can re-use it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295865

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refator

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13640)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

⌛ Testing commit 0eed39c with merge 9224938...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Oct 12, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/dirty_viewport.html
  └   → /_mozilla/css/dirty_viewport.html 111b0141f71ae09366d1ce49dcece7c79df65484
/_mozilla/css/dirty_viewport_ref.html 068fd52a0e48bc9f97e4b141e6c2d91351ec8dc4
Testing 111b0141f71ae09366d1ce49dcece7c79df65484 == 068fd52a0e48bc9f97e4b141e6c2d91351ec8dc4
@jdm
Copy link
Member

jdm commented Oct 12, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

⌛ Testing commit 0eed39c with merge 626d093...
bors-servo added a commit that referenced this pull request Oct 12, 2016
@bors-servo
Auto merge of #13640 - servo:CSSStyleDeclaration_in_style, r=mbrubeck
Loading status checks…
626d093 
Move some of the CSSStyleDeclaration logic to the style crate

<!-- Please describe your changes on the following line: -->

… so that Stylo can re-use it.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295865

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because refator

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13640)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 0eed39c into master Oct 12, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the CSSStyleDeclaration_in_style branch Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@SimonSapin @emilio @bors-servo @mbrubeck @Manishearth @highfive @jdm
You can’t perform that action at this time.