Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.14.0-nightly (19ac57926 2016-10-08) #13649

Merged
merged 2 commits into from Oct 10, 2016
Merged

Update to Rust 1.14.0-nightly (19ac57926 2016-10-08) #13649

merged 2 commits into from Oct 10, 2016

Conversation

@nox
Copy link
Member

nox commented Oct 8, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Oct 8, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/lib.rs, components/style/values/specified/mod.rs
  • @asajeffrey: components/constellation/lib.rs, components/constellation/Cargo.toml
  • @fitzgen: components/devtools_traits/Cargo.toml, components/devtools_traits/Cargo.toml, components/profile/Cargo.toml, components/profile_traits/Cargo.toml, components/profile_traits/Cargo.toml, components/devtools/Cargo.toml, components/devtools/lib.rs, components/profile_traits/lib.rs, components/profile_traits/lib.rs, components/devtools_traits/lib.rs, components/devtools_traits/lib.rs, components/profile/lib.rs
  • @KiChjang: components/script/Cargo.toml, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/lib.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/bindings/cell.rs, components/net/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
@highfive
Copy link

highfive commented Oct 8, 2016

warning Warning warning

  • These commits modify net, style, layout, gfx, and script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Oct 8, 2016

If merged right now, this does hundreds of spurious warnings because of rust-lang/rust#37034.
@nox
Copy link
Member Author

nox commented Oct 8, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2016

⌛ Trying commit 3e7c686 with merge 599da20...
bors-servo added a commit that referenced this pull request Oct 8, 2016
@bors-servo
Auto merge of #13649 - servo:rustup, r=<try>
Loading status checks…
599da20 
(Do not merge) Update to Rust 1.14.0-nightly (ad19c32a5 2016-10-06)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13649)
<!-- Reviewable:end -->
@nox nox mentioned this pull request Oct 8, 2016
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2016

💔 Test failed - linux-dev
@nox nox force-pushed the rustup branch from 3e7c686 to e0547c5 Oct 9, 2016
@highfive highfive removed the S-tests-failed label Oct 9, 2016
@nox nox force-pushed the rustup branch from e0547c5 to 0e092ef Oct 9, 2016
@nox nox changed the title (Do not merge) Update to Rust 1.14.0-nightly (ad19c32a5 2016-10-06) (Do not merge) Update to Rust 1.14.0-nightly (6e8f92f11 2016-10-07) Oct 9, 2016
@nox nox force-pushed the rustup branch from 0e092ef to e27bb6a Oct 9, 2016
@nox
Copy link
Member Author

nox commented Oct 9, 2016

This can be merged but triggers 720 spurious warnings. The nightly that was supposed to land today include a fix for the warnings, but the build failed. Should I just go ahead with this nightly even if it outputs stupid warnings?
@nox
Copy link
Member Author

nox commented Oct 9, 2016

OK, I was wrong. The nightlies are uploaded to S3 only when all the boxes finished building, and that wasn't the last remaining build. Things should be ok in one hour.
@nox nox changed the title (Do not merge) Update to Rust 1.14.0-nightly (6e8f92f11 2016-10-07) (Do not merge) Update to Rust 1.14.0-nightly (19ac57926 2016-10-08) Oct 9, 2016
@nox nox changed the title (Do not merge) Update to Rust 1.14.0-nightly (19ac57926 2016-10-08) Update to Rust 1.14.0-nightly (19ac57926 2016-10-08) Oct 9, 2016
@nox nox force-pushed the rustup branch from e27bb6a to 0ab1f41 Oct 9, 2016
@jdm
Copy link
Member

jdm commented Oct 9, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2016

📌 Commit 0ab1f41 has been approved by jdm
@highfive highfive assigned jdm and unassigned wafflespeanut Oct 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2016

⌛ Testing commit 0ab1f41 with merge 9535c3f...
@nox
Copy link
Member Author

nox commented Oct 9, 2016

@bors-servo retry
@nox
Copy link
Member Author

nox commented Oct 9, 2016

#13662
@nox
Copy link
Member Author

nox commented Oct 9, 2016

@bors-servo p=10
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2016

⌛ Testing commit 1854566 with merge 948f0ac...
bors-servo added a commit that referenced this pull request Oct 9, 2016
@bors-servo
Auto merge of #13649 - servo:rustup, r=larsbergstrom
Loading status checks…
948f0ac 
Update to Rust 1.14.0-nightly (19ac57926 2016-10-08)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13649)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Oct 9, 2016 

  ▶ Unexpected subtest result in /html/webappapis/scripting/event-loops/microtask_after_raf.html:
  └ PASS [expected FAIL] Microtask execute immediately after script
@nox
Copy link
Member Author

nox commented Oct 9, 2016

@bors-servo retry #13501
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2016

⌛ Testing commit 1854566 with merge 66ed39c...
bors-servo added a commit that referenced this pull request Oct 9, 2016
@bors-servo
Auto merge of #13649 - servo:rustup, r=larsbergstrom
Loading status checks…
66ed39c 
Update to Rust 1.14.0-nightly (19ac57926 2016-10-08)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13649)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Oct 9, 2016 

  ▶ Unexpected subtest result in /html/webappapis/scripting/event-loops/microtask_after_raf.html:
  └ PASS [expected FAIL] Microtask execute immediately after script
@nox
Copy link
Member Author

nox commented Oct 9, 2016

@bors-servo retry #13501
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

⌛ Testing commit 1854566 with merge 39d3fce...
bors-servo added a commit that referenced this pull request Oct 10, 2016
@bors-servo
Auto merge of #13649 - servo:rustup, r=larsbergstrom
Loading status checks…
39d3fce 
Update to Rust 1.14.0-nightly (19ac57926 2016-10-08)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13649)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 1854566 into master Oct 10, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
dependency-ci Failed dependency checks
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the rustup branch Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@nox @highfive @bors-servo @jdm @larsbergstrom @Manishearth @wafflespeanut
You can’t perform that action at this time.