HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. #13659
+11
−5
HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_e…
…lement. Fixes #10520.
- Loading branch information
commit ee9a5b7df1c32a859ef7767d339c41efba55ac11
| @@ -272,9 +272,13 @@ impl HTMLElementMethods for HTMLElement { | ||
|
|
||
| // https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsetparent | ||
| fn GetOffsetParent(&self) -> Option<Root<Element>> { | ||
| if self.is::<HTMLBodyElement>() || self.is::<HTMLHtmlElement>() { | ||
| if self.is::<HTMLHtmlElement>() { | ||
|
||
| return None; | ||
| } | ||
| match self.downcast::<HTMLBodyElement>() { | ||
| Some(e) if e.is_the_html_body_element() => return None, | ||
| _ => (), | ||
| } | ||
|
|
||
| let node = self.upcast::<Node>(); | ||
| let window = window_from_node(self); | ||
| @@ -285,8 +289,9 @@ impl HTMLElementMethods for HTMLElement { | ||
|
|
||
| // https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsettop | ||
| fn OffsetTop(&self) -> i32 { | ||
| if self.is::<HTMLBodyElement>() { | ||
| return 0; | ||
| match self.downcast::<HTMLBodyElement>() { | ||
| Some(e) if e.is_the_html_body_element() => return 0, | ||
| _ => (), | ||
| } | ||
|
|
||
| let node = self.upcast::<Node>(); | ||
| @@ -298,8 +303,9 @@ impl HTMLElementMethods for HTMLElement { | ||
|
|
||
| // https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsetleft | ||
| fn OffsetLeft(&self) -> i32 { | ||
| if self.is::<HTMLBodyElement>() { | ||
| return 0; | ||
| match self.downcast::<HTMLBodyElement>() { | ||
| Some(e) if e.is_the_html_body_element() => return 0, | ||
| _ => (), | ||
| } | ||
|
|
||
| let node = self.upcast::<Node>(); | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is incorrect, an
htmlelement can be the child of whatever. The test really needs to be about the root element.