Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement the constructor for EventSource #13666
Conversation
highfive
commented
Oct 10, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 10, 2016
|
@bors-servo try |
|
|
|
It's not clear to me why we'd want to create a js promise here at all. |
|
How else would you fetch the request? |
|
With all the usual infra, like you did for the script element. |
|
An EventSource needs to have an associated Request object. I recall @jdm saying that we should store a dom::Request instead of a net_traits::Request, and by doing so, the straightforward way to fetch a dom::Request would be via dom::Fetch. I could instead make a function that transforms this dom::Request into a RequestInit, and then properly fetch it using the document_loader stuff, but if so, I think we're better off storing a RequestInit instead. |
9064f32
to
13f5ce6
|
Not sure if there's any value in merging just the EventSource constructor here, since it doesn't make any failing tests pass. |
|
Agreed. |
KiChjang commentedOct 10, 2016
•
edited by larsbergstrom
Partial #8925.
This change is