Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the fetch stack for HTMLMediaElement. #13677

Merged
merged 1 commit into from Oct 11, 2016
Merged

Use the fetch stack for HTMLMediaElement. #13677

merged 1 commit into from Oct 11, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 10, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Use the fetch stack for HTMLMediaElement.
Loading status checks…
490fff2
@highfive
Copy link

highfive commented Oct 10, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmlmediaelement.rs
@highfive
Copy link

highfive commented Oct 10, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth
Manishearth reviewed Oct 10, 2016
View changes
components/script/dom/htmlmediaelement.rs
unreachable!("Unexpected HTMLMediaElement")
};

let request = RequestInit {

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Oct 10, 2016

Member

This should be https://html.spec.whatwg.org/multipage/infrastructure.html#create-a-potential-cors-request ?

This comment has been minimized.

Sign in to view
Copy link
@Ms2ger

Ms2ger Oct 10, 2016

Author Contributor

Yes, it is; specialized to the case where we don't pay attention to the crossorigin attribute.

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Oct 10, 2016

Member

Ah, okay. r=me then
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 11, 2016

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

📌 Commit 490fff2 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

⌛ Testing commit 490fff2 with merge 004787b...
bors-servo added a commit that referenced this pull request Oct 11, 2016
@bors-servo
Auto merge of #13677 - servo:media-fetch, r=Manishearth
Loading status checks…
004787b 
Use the fetch stack for HTMLMediaElement.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13677)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

💔 Test failed - mac-rel-wpt2
@KiChjang
Copy link
Member

KiChjang commented Oct 11, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

⌛ Testing commit 490fff2 with merge be9ac7c...
bors-servo added a commit that referenced this pull request Oct 11, 2016
@bors-servo
Auto merge of #13677 - servo:media-fetch, r=Manishearth
Loading status checks…
be9ac7c 
Use the fetch stack for HTMLMediaElement.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13677)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Oct 11, 2016 

  ▶ Unexpected subtest result in /html/webappapis/scripting/event-loops/microtask_after_raf.html:
  └ PASS [expected FAIL] Microtask execute immediately after script
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 11, 2016

@bors-servo retry #13501
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

⌛ Testing commit 490fff2 with merge 3027b3b...
bors-servo added a commit that referenced this pull request Oct 11, 2016
@bors-servo
Auto merge of #13677 - servo:media-fetch, r=Manishearth
Loading status checks…
3027b3b 
Use the fetch stack for HTMLMediaElement.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13677)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Oct 11, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/inline_block_opacity_change.html
  └   → /_mozilla/css/inline_block_opacity_change.html aed6845267bba6c52d3aa69c4889449b454d8117
/_mozilla/css/inline_block_opacity_change_ref.html febec1b4730afab195f280694dad47200b09ea3c
Testing aed6845267bba6c52d3aa69c4889449b454d8117 == febec1b4730afab195f280694dad47200b09ea3c
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 11, 2016 •
edited by jdm

@bors-servo retry
#13360
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, windows-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Oct 11, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

⌛ Testing commit 490fff2 with merge 51bcf51...
bors-servo added a commit that referenced this pull request Oct 11, 2016
@bors-servo
Auto merge of #13677 - servo:media-fetch, r=Manishearth
Loading status checks…
51bcf51 
Use the fetch stack for HTMLMediaElement.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13677)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 490fff2 into master Oct 11, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the media-fetch branch Nov 3, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
31 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Ms2ger @highfive @bors-servo @KiChjang @jdm @Manishearth @wafflespeanut
You can’t perform that action at this time.