Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplayout: Don't use the existing block position as the float ceiling when placing block formatting contexts in the sequential fallback. #13685
Conversation
placing block formatting contexts in the sequential fallback. The existing block position isn't yet computed at that time, so it contains junk data. It just so happened to work on first reflow because that value is usually set to zero, but it usually failed on subsequent reflows. Improves certain Wikipedia pages. Closes #13630 (though Google is still broken; it was a separate bug and will be split off into a separate issue).
highfive
commented
Oct 11, 2016
|
|
|
Now that I look at the code again, what I intended for that member variable to do is probably already being covered by @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2016
…cement, r=notriddle layout: Don't use the existing block position as the float ceiling when placing block formatting contexts in the sequential fallback. The existing block position isn't yet computed at that time, so it contains junk data. It just so happened to work on first reflow because that value is usually set to zero, but it usually failed on subsequent reflows. Improves certain Wikipedia pages. Closes #13630 (though Google is still broken; it was a separate bug and will be split off into a separate issue). r? @notriddle <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13685) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry Timeout in DOM APIs, doesn't look related |
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2016
…cement, r=notriddle layout: Don't use the existing block position as the float ceiling when placing block formatting contexts in the sequential fallback. The existing block position isn't yet computed at that time, so it contains junk data. It just so happened to work on first reflow because that value is usually set to zero, but it usually failed on subsequent reflows. Improves certain Wikipedia pages. Closes #13630 (though Google is still broken; it was a separate bug and will be split off into a separate issue). r? @notriddle <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13685) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 11, 2016
•
edited by larsbergstrom
The existing block position isn't yet computed at that time, so it
contains junk data. It just so happened to work on first reflow because
that value is usually set to zero, but it usually failed on subsequent
reflows.
Improves certain Wikipedia pages.
Closes #13630 (though Google is still broken; it was a separate bug and
will be split off into a separate issue).
r? @notriddle
This change is