Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstylo: Use AtomicRefCell for PerDocumentStyleData #13688
Merged
+42
−30
Conversation
highfive
commented
Oct 11, 2016
|
|
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2016
stylo: Use AtomicRefCell for PerDocumentStyleData Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1309090 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13688) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2016
stylo: Use AtomicRefCell for PerDocumentStyleData Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1309090 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13688) <!-- Reviewable:end -->
|
|
MozReview-Commit-ID: 27JeRluDAo3
|
@bors-servo r=Manishearth |
|
|
|
@Manishearth thanks for doing #13620! Already paid off in this PR, where I forgot to update the signatures of the Servo_* functions in glue.rs. Testing and infra FTW! |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2016
stylo: Use AtomicRefCell for PerDocumentStyleData Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1309090 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13688) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bholley commentedOct 11, 2016
•
edited by larsbergstrom
Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1309090
This change is