Correct the unicode codes used for tree printing #13693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were converted from inline UTF-8 to escape sequences, but the sequences should be in hexadecimal instead of decimal.
highfive
added
the
S-awaiting-review
|
For reference this issue was introduced here: b5a04a6 |
|
Looks good to me, I'll trust that the character codes are the correct ones. @bors-servo: r+ |
|
📌 Commit b0b7068 has been approved by |
highfive
added
S-awaiting-merge
|
Nice find, I was wondering why Chinese characters were showing up there :) I actually went through my Terminal settings thinking that I had accidentally changed my encoding... |
bors-servo
pushed a commit
that referenced
this pull request
Oct 11, 2016
Correct the unicode codes used for tree printing <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the tree printing code is untested and this is just a correction of a build fix. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> These were converted from inline UTF-8 to escape sequences, but the sequences should be in hexadecimal instead of decimal. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13693) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
highfive
removed
the
S-awaiting-merge
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThese were converted from inline UTF-8 to escape sequences, but the
sequences should be in hexadecimal instead of decimal.
This change is