Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing `c_void` error when building for Android #13697

Merged
merged 1 commit into from Oct 12, 2016

Conversation

@mmatyas
Copy link
Contributor

mmatyas commented Oct 11, 2016

Including c_void is also required on Android, because of https://github.com/mmatyas/servo/blob/master/ports/glutin/window.rs#L170

(This is a fix for #13154)


This change is Reviewable

@emilio
Copy link
Member

emilio commented Oct 11, 2016

@bors-servo: r+

Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2016

📌 Commit 4793f93 has been approved by emilio

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

Testing commit 4793f93 with merge f4cb87a...

bors-servo added a commit that referenced this pull request Oct 12, 2016
Fix missing `c_void` error when building for Android

<!-- Please describe your changes on the following line: -->
Including `c_void` is also required on Android, because of https://github.com/mmatyas/servo/blob/master/ports/glutin/window.rs#L170

(This is a fix for #13154)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13697)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

💔 Test failed - linux-rel-css

@jdm
Copy link
Member

jdm commented Oct 12, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

Previous build results for arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-css...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

@bors-servo bors-servo merged commit 4793f93 into servo:master Oct 12, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.