Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove test-geckolib, run test-stylo on travis #13722
Merged
Conversation
highfive
commented
Oct 12, 2016
|
Heads up! This PR modifies the following files:
|
|
We need to fix appveyor as well. |
|
This can merge after travis and appveyor both go green. |
|
@bors-servo r=jdm green now |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 12, 2016
Remove test-geckolib, run test-stylo on travis test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing. Fixes #13721 r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722) <!-- Reviewable:end -->
|
|
highfive
commented
Oct 12, 2016
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 13, 2016
Remove test-geckolib, run test-stylo on travis test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing. Fixes #13721 r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722) <!-- Reviewable:end -->
|
|
highfive
commented
Oct 13, 2016
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 13, 2016
Remove test-geckolib, run test-stylo on travis test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing. Fixes #13721 r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
@bors-servo p=1 would be nice to have travis back |
bors-servo
added a commit
that referenced
this pull request
Oct 13, 2016
Remove test-geckolib, run test-stylo on travis test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing. Fixes #13721 r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722) <!-- Reviewable:end -->
|
|
This was referenced Oct 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedOct 12, 2016
•
edited by larsbergstrom
test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in
tests/unit/stylo. (`./mach test-stylo) Now test-geckolib does nothing.Fixes #13721
r? @jdm
This change is