Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused support for the legacy network stack in script. #13741

Merged
merged 2 commits into from Oct 13, 2016
Merged

Remove some unused support for the legacy network stack in script. #13741

merged 2 commits into from Oct 13, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 13, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 2 commits Oct 10, 2016
@Ms2ger
Remove Document::load_async.
7b905a5
@Ms2ger
Remove DocumentLoader::pipeline.
Loading status checks…
d0323e3
@highfive
Copy link

highfive commented Oct 13, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/script_thread.rs, components/script/dom/document.rs, components/script/document_loader.rs
@highfive
Copy link

highfive commented Oct 13, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 13, 2016

Reviewed in #13714.

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2016

📌 Commit d0323e3 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2016

⌛ Testing commit d0323e3 with merge 740464d...
bors-servo added a commit that referenced this pull request Oct 13, 2016
@bors-servo
Auto merge of #13741 - servo:fetch-doc-unused, r=Manishearth
Loading status checks…
740464d 
Remove some unused support for the legacy network stack in script.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13741)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit d0323e3 into master Oct 13, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 13, 2016
Merged
3 of 3 tasks complete
@Ms2ger Ms2ger deleted the fetch-doc-unused branch Oct 13, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
31 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Ms2ger @highfive @bors-servo @Manishearth
You can’t perform that action at this time.