Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement blob url support in the fetch stack. #13750
Merged
+237
−64
Conversation
highfive
commented
Oct 13, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 13, 2016
Implement blob url support in the fetch stack.
Ms2ger
force-pushed the
fetch-blob
branch
3 times, most recently
from
8ce01a9
to
699287e
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 14, 2016
Implement blob url support in the fetch stack. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13750) <!-- Reviewable:end -->
|
|
|
r? @Manishearth |
|
There should be passing tests here, if not add some. |
components/net/filemanager_thread.rs
Outdated
| let _ = sender.send(Err(FileManagerThreadError::BlobURLStoreError(e))); | ||
| } | ||
| }) | ||
| if let Err(e) = store.try_read_file(&sender, id, check_url_validity, |
This comment has been minimized.
This comment has been minimized.
Manishearth
Oct 14, 2016
Member
file I/O is slow too, shouldn't we spawn a thread for that? ditto for promotememory
components/net/blob_loader.rs
Outdated
| @@ -119,3 +120,71 @@ fn load_blob<UI: 'static + UIProvider> | |||
| send_error(load_data.url.clone(), format_err, start_chan); | |||
| } | |||
| } | |||
|
|
|||
| // TODO: make async. | |||
| pub fn load_blob_sync<UI: 'static + UIProvider> | |||
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=Manishearth |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 14, 2016
Implement blob url support in the fetch stack. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13750) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedOct 13, 2016
•
edited by larsbergstrom
This change is