Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'font-kerning' in geckolib #13751

Merged
merged 1 commit into from Oct 14, 2016
Merged

Add support for 'font-kerning' in geckolib #13751

merged 1 commit into from Oct 14, 2016

Conversation

@joewalker
Copy link
Contributor

joewalker commented Oct 13, 2016 •
edited

Add support for 'font-kerning' in geckolib
These changes fix #13667

$ ./mach build -d
It looks like you passed an unrecognized argument into mach.

$ ./mach test-tidy
It looks like you are trying to run an unknown mach command: test-tidy

I'm clearly doing something wrong here, but I'm not sure what

This change is Reviewable
@highfive
Copy link

highfive commented Oct 13, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.
@highfive
Copy link

highfive commented Oct 13, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs
@highfive
Copy link

highfive commented Oct 13, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@wafflespeanut
Copy link
Member

wafflespeanut commented Oct 13, 2016

The changes look perfect! For testing, try ./mach build && ./mach run test.html --disable-e10s

The commands in the template are specific to servo's mach, and hence they won't be recognized by stylo's mach 😄
@wafflespeanut wafflespeanut assigned wafflespeanut and unassigned nox Oct 13, 2016
@joewalker
Copy link
Contributor Author

joewalker commented Oct 13, 2016

Sorry forgot to attach screenshots:

Before:
stylo-before

After:
stylo-after
@wafflespeanut
wafflespeanut reviewed Oct 13, 2016
View changes
components/style/properties/gecko.mako.rs Outdated
<% kerning_keyword = Keyword("font-kerning", "auto normal none",
gecko_constant_prefix='NS_FONT_KERNING') %>

${impl_keyword('font_kerning', 'mFont.kerning', kerning_keyword, need_clone=False, cast_type='u8')}

This comment has been minimized.

Sign in to view
@wafflespeanut

wafflespeanut Oct 13, 2016 •
edited

Member

By default, it's casted to u8, so we won't be needing cast_type=u8

This comment has been minimized.

Sign in to view
@joewalker

joewalker Oct 13, 2016

Author Contributor

Ah, OK. Fixed in b4e91f6
@wafflespeanut
Copy link
Member

wafflespeanut commented Oct 13, 2016

Once that tiny change is addressed, we'll go ahead and land this :)
@joewalker
Copy link
Contributor Author

joewalker commented Oct 13, 2016

Maybe you'd prefer me to squash those commits?
@KiChjang
Copy link
Member

KiChjang commented Oct 14, 2016

Yes, please squash.
@joewalker
Add support for 'font-kerning' in geckolib
Loading status checks…
a2d3ea5
@joewalker joewalker force-pushed the joewalker:font-kerning branch from b4e91f6 to a2d3ea5 Oct 14, 2016
@joewalker
Copy link
Contributor Author

joewalker commented Oct 14, 2016

Squashed and rebased.
@Manishearth
Copy link
Member

Manishearth commented Oct 14, 2016

@bors-servo r+

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2016

📌 Commit a2d3ea5 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2016

⌛ Testing commit a2d3ea5 with merge b94f074...
bors-servo added a commit that referenced this pull request Oct 14, 2016
@bors-servo
Auto merge of #13751 - joewalker:font-kerning, r=Manishearth
Loading status checks…
b94f074 
Add support for 'font-kerning' in geckolib

Add support for 'font-kerning' in geckolib
These changes fix #13667

    $ ./mach build -d
    It looks like you passed an unrecognized argument into mach.

    $ ./mach test-tidy
    It looks like you are trying to run an unknown mach command: test-tidy

I'm clearly doing something wrong here, but I'm not sure what

- [x] These changes do not require tests because "[For stylo it's okay to not have tests since many of the reftests fail due to unrelated reasons](#13570 (comment))" :)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13751)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit a2d3ea5 into servo:master Oct 14, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@joewalker joewalker deleted the joewalker:font-kerning branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wafflespeanut wafflespeanut

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Stylo: Implement font-kerning
7 participants
@joewalker @highfive @wafflespeanut @KiChjang @Manishearth @bors-servo @nox
You can’t perform that action at this time.