Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPartial fix for 12415 #13803
Merged
Partial fix for 12415 #13803
Conversation
highfive
commented
Oct 17, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon. |
highfive
commented
Oct 17, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 17, 2016
Partial fix for 12415 <!-- Please describe your changes on the following line: --> Fix interface exposure for Bluetooth, which ended up pulling a longer thread of other interfaces into it. Per @jdm just went ahead and did all of the interfaces that `./mach build -d` errored on, so there are a lot of interfaces here. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix (partially) #12415 <!-- Either: --> - [x] These changes do not require tests because they only removed code <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13803) <!-- Reviewable:end -->
|
|
highfive
commented
Oct 17, 2016
|
|
On it! |
|
Neat! @bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 17, 2016
Partial fix for 12415 <!-- Please describe your changes on the following line: --> Fix interface exposure for Bluetooth, which ended up pulling a longer thread of other interfaces into it. Per @jdm just went ahead and did all of the interfaces that `./mach build -d` errored on, so there are a lot of interfaces here. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix (partially) #12415 <!-- Either: --> - [x] These changes do not require tests because they only removed code <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13803) <!-- Reviewable:end -->
|
|
highfive
commented
Oct 17, 2016
|
|
@bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
scotttrinh commentedOct 17, 2016
•
edited by jdm
Fix interface exposure for Bluetooth, which ended up pulling a longer thread of other interfaces into it. Per @jdm just went ahead and did all of the interfaces that
./mach build -derrored on, so there are a lot of interfaces here../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is