Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Don't delete non-text boxes from the list of input boxes when #1381

Merged
merged 1 commit into from Dec 12, 2013

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Dec 11, 2013

flushing text clumps. Fixes this page:

http://en.wikipedia.org/wiki/Yellow_River

This is not the most efficient thing to do; a FIXME has been added
noting what is most correct.

r? @jdm

flushing text clumps. Fixes this page:

    http://en.wikipedia.org/wiki/Yellow_River

This is not the most efficient thing to do; a FIXME has been added
noting what is most correct.
@highfive
Copy link

highfive commented Dec 11, 2013

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @pcwalton, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!
@pcwalton
Copy link
Contributor Author

pcwalton commented Dec 11, 2013

See #1319

@jdm

This comment has been minimized.

Copy link

jdm commented on dcacab8 Dec 11, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on dcacab8 Dec 11, 2013

saw approval from jdm
at pcwalton@dcacab8

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 11, 2013

merging pcwalton/servo/bogus-box-deletion = dcacab8 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 11, 2013

pcwalton/servo/bogus-box-deletion = dcacab8 merged ok, testing candidate = acb3d9f

This comment has been minimized.

Copy link
Contributor

bors-servo replied Dec 12, 2013

fast-forwarding master to auto = acb3d9f

bors-servo pushed a commit that referenced this pull request Dec 11, 2013
flushing text clumps. Fixes this page:

    http://en.wikipedia.org/wiki/Yellow_River

This is not the most efficient thing to do; a FIXME has been added
noting what is most correct.

r? @jdm
@bors-servo bors-servo merged commit dcacab8 into servo:master Dec 12, 2013
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.