Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html5ever to 0.8 #13813

Merged
merged 2 commits into from Nov 3, 2016
Merged

Update html5ever to 0.8 #13813

merged 2 commits into from Nov 3, 2016
+97 −56

Conversation

@nox
Copy link
Member

nox commented Oct 18, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Oct 18, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/servoparser/html.rs, components/script/Cargo.toml
  • @KiChjang: components/script/dom/servoparser/html.rs, components/script/Cargo.toml
@highfive
Copy link

highfive commented Oct 18, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox nox force-pushed the nox:h5e branch from e921036 to 03e308d Oct 18, 2016
@SimonSapin
Copy link
Member

SimonSapin commented Oct 18, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 18, 2016

📌 Commit 03e308d has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned metajack Oct 18, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

☔ The latest upstream changes (presumably #13949) made this pull request unmergeable. Please resolve the merge conflicts.
@nox nox force-pushed the nox:h5e branch from 0b8754a to f674651 Oct 28, 2016
@nox nox changed the title Bump html5ever to 0.6 Update html5ever to 0.8 Oct 28, 2016
@SimonSapin SimonSapin mentioned this pull request Oct 29, 2016
Merged
@SimonSapin
Copy link
Member

SimonSapin commented Nov 2, 2016

@bors-servo p=100

I have a pile of things blocked on this.
@KiChjang
Copy link
Member

KiChjang commented Nov 2, 2016 

error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
thread 'rustc' panicked at 'assertion failed: bpos.to_usize() >= mbc.pos.to_usize() + mbc.bytes', ../src/libsyntax/codemap.rs:707
note: Run with `RUST_BACKTRACE=1` for a backtrace.
error: Could not compile `servo`.

Rust ICE. Fun!
@SimonSapin
Copy link
Member

SimonSapin commented Nov 2, 2016

This ICE is fixed in today’s nightly, rustup coming up.
@SimonSapin
Copy link
Member

SimonSapin commented Nov 2, 2016

Rebased on top of rustup https://github.com/servo/servo/compare/h5eup
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

☔ The latest upstream changes (presumably #14028) made this pull request unmergeable. Please resolve the merge conflicts.
@nox
Update syn and quote
5005d36
@nox nox force-pushed the nox:h5e branch from f674651 to 2a9a08c Nov 3, 2016
@nox nox removed the S-needs-rebase label Nov 3, 2016
@nox
Copy link
Member Author

nox commented Nov 3, 2016

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

📌 Commit 2a9a08c has been approved by SimonSapin
bors-servo added a commit that referenced this pull request Nov 3, 2016
@bors-servo
Auto merge of #13813 - nox:h5e, r=SimonSapin
Loading status checks…
f595160 
Update html5ever to 0.8

<!-- Reviewable:start -->

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13813)

<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

⌛ Testing commit 2a9a08c with merge f595160...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

💔 Test failed - linux-rel-wpt
@nox
Update html5ever to 0.8
Loading status checks…
7cb0955
@nox nox force-pushed the nox:h5e branch from 2a9a08c to 7cb0955 Nov 3, 2016
@SimonSapin
Copy link
Member

SimonSapin commented Nov 3, 2016

@bors-servo r+

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

📌 Commit 7cb0955 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

⌛ Testing commit 7cb0955 with merge 931f759...
bors-servo added a commit that referenced this pull request Nov 3, 2016
@bors-servo
Auto merge of #13813 - nox:h5e, r=SimonSapin
Loading status checks…
931f759 
Update html5ever to 0.8

<!-- Reviewable:start -->

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13813)

<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 3, 2016 

  ▶ FAIL [expected PASS] /_mozilla/mozilla/iframe/resize_after_load.html
  └   → /_mozilla/mozilla/iframe/resize_after_load.html bde0cd2bf9e9491ac2b88940b1e4036bfa98f6aa
/_mozilla/mozilla/iframe/resize_after_load_ref.html 111b0141f71ae09366d1ce49dcece7c79df65484
Testing bde0cd2bf9e9491ac2b88940b1e4036bfa98f6aa == 111b0141f71ae09366d1ce49dcece7c79df65484
@nox
Copy link
Member Author

nox commented Nov 3, 2016

@bors-servo retry #13573
@nox nox added S-awaiting-merge and removed S-tests-failed labels Nov 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

⌛ Testing commit 7cb0955 with merge 9fcc9d9...
bors-servo added a commit that referenced this pull request Nov 3, 2016
@bors-servo
Auto merge of #13813 - nox:h5e, r=SimonSapin
Loading status checks…
9fcc9d9 
Update html5ever to 0.8

<!-- Reviewable:start -->

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13813)

<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 7cb0955 into servo:master Nov 3, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:h5e branch Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @SimonSapin @bors-servo @KiChjang @metajack
You can’t perform that action at this time.