Move some types out of msg. #13816

Ms2ger · 2016-10-18T16:10:57Z

This change is

highfive · 2016-10-18T16:11:01Z

Heads up! This PR modifies the following files:

@asajeffrey: components/constellation/pipeline.rs, components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml, components/constellation/constellation.rs
@jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
@fitzgen: components/script/dom/request.rs, components/script/dom/xmlhttprequest.rs, components/script/dom/window.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs, components/script/dom/workerglobalscope.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/script_thread.rs, components/script/dom/htmliframeelement.rs, components/script/dom/htmlanchorelement.rs, components/script/dom/htmlformelement.rs, components/script/dom/bindings/trace.rs, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
@KiChjang: components/script/dom/request.rs, components/script/dom/xmlhttprequest.rs, components/script/dom/window.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs, components/net/http_loader.rs, components/script/dom/workerglobalscope.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/net_traits/image_cache_thread.rs, components/net_traits/image_cache_thread.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/net/file_loader.rs, components/net_traits/image/base.rs, components/net_traits/image/base.rs, components/script/script_thread.rs, components/net/image_cache_thread.rs, components/script/dom/htmliframeelement.rs, components/net/fetch/methods.rs, components/script/dom/htmlanchorelement.rs, components/script/dom/htmlformelement.rs, components/script/dom/bindings/trace.rs, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml, components/net_traits/request.rs, components/net_traits/request.rs

highfive · 2016-10-18T16:11:02Z

Warning

These commits modify net and script code, but no tests are modified. Please consider adding a test!

nox · 2016-10-18T16:13:59Z

@bors-servo r+

bors-servo · 2016-10-18T16:14:00Z

📌 Commit 980991b has been approved by nox

bors-servo · 2016-10-18T16:55:26Z

⌛ Testing commit 980991b with merge 692f263...


        Auto merge of #13816 - servo:msg-crate, r=nox

Move some types out of msg.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13816)

bors-servo · 2016-10-18T17:10:38Z

💔 Test failed - mac-dev-unit

jdm · 2016-10-18T17:53:42Z

error[E0432]: unresolved import `msg::constellation_msg::ReferrerPolicy`
  --> /Users/servo/buildbot/slave/mac-dev-unit/build/tests/unit/net/data_loader.rs:10:42
   |
10 | use msg::constellation_msg::{PipelineId, ReferrerPolicy};
   |                                          ^^^^^^^^^^^^^^ no `ReferrerPolicy` in `msg::constellation_msg`

error[E0432]: unresolved import `msg::constellation_msg::ReferrerPolicy`
  --> /Users/servo/buildbot/slave/mac-dev-unit/build/tests/unit/net/fetch.rs:23:30
   |
23 | use msg::constellation_msg::{ReferrerPolicy, TEST_PIPELINE_ID};
   |                              ^^^^^^^^^^^^^^ no `ReferrerPolicy` in `msg::constellation_msg`

error[E0432]: unresolved import `msg::constellation_msg::ReferrerPolicy`
 --> /Users/servo/buildbot/slave/mac-dev-unit/build/tests/unit/net/resource_thread.rs:6:42
  |
6 | use msg::constellation_msg::{PipelineId, ReferrerPolicy};
  |                                          ^^^^^^^^^^^^^^ no `ReferrerPolicy` in `msg::constellation_msg`

error[E0432]: unresolved import `msg::constellation_msg::ReferrerPolicy`
  --> /Users/servo/buildbot/slave/mac-dev-unit/build/tests/unit/net/http_loader.rs:21:42
   |
21 | use msg::constellation_msg::{PipelineId, ReferrerPolicy, TEST_PIPELINE_ID};
   |                                          ^^^^^^^^^^^^^^ no `ReferrerPolicy` in `msg::constellation_msg`

bors-servo · 2016-10-21T13:36:02Z

☔ The latest upstream changes (presumably #13878) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2016-11-02T09:29:47Z

☔ The latest upstream changes (presumably #13742) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2016-11-02T17:02:55Z

☔ The latest upstream changes (presumably #13961) made this pull request unmergeable. Please resolve the merge conflicts.

Ms2ger · 2016-11-03T15:28:42Z

@bors-servo r=nox

bors-servo · 2016-11-03T15:28:44Z

📌 Commit a9a9ac8 has been approved by nox

bors-servo · 2016-11-03T18:06:45Z

☔ The latest upstream changes (presumably #14043) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2016-11-04T07:43:34Z

🔒 Merge conflict


        Move ReferrerPolicy to net_traits.

Ms2ger · 2016-11-04T09:44:09Z

@bors-servo r=nox

bors-servo · 2016-11-04T09:44:10Z

📌 Commit 277c6d0 has been approved by nox

bors-servo · 2016-11-04T10:26:28Z

⌛ Testing commit 277c6d0 with merge be58dc3...


        Auto merge of #13816 - servo:msg-crate, r=nox

Move some types out of msg.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13816)

bors-servo · 2016-11-04T11:43:54Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

highfive assigned SimonSapin Oct 18, 2016

highfive added the S-awaiting-review label Oct 18, 2016

highfive assigned nox and unassigned SimonSapin Oct 18, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 18, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 18, 2016

Ms2ger force-pushed the msg-crate branch from 980991b to fc6181f Oct 19, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Oct 19, 2016

This was referenced Oct 21, 2016

Move LoadData to script_traits. #13878

Merged

Move Image and PixelFormat to net_traits. #13880

Merged

highfive added the S-needs-rebase label Oct 21, 2016

Ms2ger mentioned this pull request Oct 22, 2016

Move WindowSizeType to script_traits. #13891

Merged

Ms2ger force-pushed the msg-crate branch from fc6181f to b45f75b Oct 24, 2016

highfive added the S-needs-rebase label Nov 2, 2016

Ms2ger force-pushed the msg-crate branch from b45f75b to 0b991b6 Nov 2, 2016

highfive added the S-needs-rebase label Nov 2, 2016

Ms2ger force-pushed the msg-crate branch from 0b991b6 to a9a9ac8 Nov 3, 2016

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Nov 3, 2016

highfive added S-needs-rebase and removed S-awaiting-merge labels Nov 3, 2016

Move ReferrerPolicy to net_traits.

Loading status checks…

277c6d0

Ms2ger force-pushed the msg-crate branch from a9a9ac8 to 277c6d0 Nov 4, 2016

highfive added the S-awaiting-review label Nov 4, 2016

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Nov 4, 2016

highfive removed the S-awaiting-merge label Nov 4, 2016

This was referenced Nov 4, 2016

[WIP] Implement History State #13781

Closed

Network Security : Implement StrictOrigin and StrictOriginWhenCrossOr… #14059

Merged

Ms2ger deleted the msg-crate branch Nov 4, 2016

servo / servo

Move some types out of msg. #13816

Move some types out of msg. #13816

Ms2ger commented Oct 18, 2016 •

edited by larsbergstrom

highfive commented Oct 18, 2016

highfive commented Oct 18, 2016

nox commented Oct 18, 2016

bors-servo commented Oct 18, 2016

bors-servo commented Oct 18, 2016

bors-servo commented Oct 18, 2016

jdm commented Oct 18, 2016

bors-servo commented Oct 21, 2016

bors-servo commented Nov 2, 2016

bors-servo commented Nov 2, 2016

Ms2ger commented Nov 3, 2016

bors-servo commented Nov 3, 2016

bors-servo commented Nov 3, 2016

bors-servo commented Nov 4, 2016

Ms2ger commented Nov 4, 2016

bors-servo commented Nov 4, 2016

bors-servo commented Nov 4, 2016

bors-servo commented Nov 4, 2016

servo / servo

Join GitHub today

Move some types out of msg. #13816

Move some types out of msg. #13816

Conversation

Ms2ger commented Oct 18, 2016 • edited by larsbergstrom

highfive commented Oct 18, 2016

highfive commented Oct 18, 2016

nox commented Oct 18, 2016

bors-servo commented Oct 18, 2016

bors-servo commented Oct 18, 2016

bors-servo commented Oct 18, 2016

jdm commented Oct 18, 2016

bors-servo commented Oct 21, 2016

bors-servo commented Nov 2, 2016

bors-servo commented Nov 2, 2016

Ms2ger commented Nov 3, 2016

bors-servo commented Nov 3, 2016

bors-servo commented Nov 3, 2016

bors-servo commented Nov 4, 2016

Ms2ger commented Nov 4, 2016

bors-servo commented Nov 4, 2016

bors-servo commented Nov 4, 2016

bors-servo commented Nov 4, 2016

Ms2ger commented Oct 18, 2016 •

edited by larsbergstrom