Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWebGL support on Windows #13840
WebGL support on Windows #13840
Conversation
|
Looks pretty good! Just a few nits :) |
| @@ -642,6 +662,10 @@ impl<Window: WindowMethods> IOCompositor<Window> { | |||
| } | |||
| } | |||
|
|
|||
| (Msg::Dispatch(func), _) => { | |||
This comment has been minimized.
This comment has been minimized.
| @@ -642,6 +662,10 @@ impl<Window: WindowMethods> IOCompositor<Window> { | |||
| } | |||
| } | |||
|
|
|||
| (Msg::Dispatch(func), _) => { | |||
| func(); | |||
This comment has been minimized.
This comment has been minimized.
emilio
Oct 19, 2016
Member
Could we add a comment here like:
// The functions sent here right now are really dumb, so they can't panic. But if we start running more complex code here, we should really catch panic here.
That should be enough for now. Also, how about renaming the Dispatch message to DispatchForWebGLContextCreation (or something like that)? I don't think we want this to become a general API.
I filled servo/surfman#72, somewhat related to error handling here.
This comment has been minimized.
This comment has been minimized.
MortimerGoro
Oct 20, 2016
Author
Contributor
I think that might be useful in other future cases. The comments already say what it is used for now, but I'd bet that other API will require it too.
| @@ -126,6 +126,8 @@ pub enum Msg { | |||
| // sends a reply on the IpcSender, the constellation knows it's safe to | |||
| // tear down the other threads associated with this pipeline. | |||
| PipelineExited(PipelineId, IpcSender<()>), | |||
| /// Runs a closure in the compositor thread | |||
This comment has been minimized.
This comment has been minimized.
MortimerGoro
force-pushed the
MortimerGoro:webrender_dispatcher
branch
from
e42326b
to
c79aeda
…indows, r=emilio
MortimerGoro
force-pushed the
MortimerGoro:webrender_dispatcher
branch
from
c79aeda
to
b1b074e
|
#13843 is ready. Rebased ;) |
|
@bors-servo: r+ |
|
|
|
@MortimerGoro If you have a screenshot I'll try to make sure it appears featured in TWIS :-) |
WebGL support on Windows <!-- Please describe your changes on the following line: --> This is the final step to provide WebGL support on Windows ;) Some Related PRs already merged in webrender and offscreen-gl-context: servo/surfman#64 servo/webrender#432 --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13840) <!-- Reviewable:end -->
|
|
|
@emilio Awesome, here is a screenshot of a WebGL animation. We could also mention that the WebVR API is coming to Servo. I've working on it and already have a core component that works outside servo. The next milestone is integrating it into servo. We'll publish a blogpost about that in mozvr blog in 1-2 days.
|
MortimerGoro commentedOct 19, 2016
•
edited by jdm
This is the final step to provide WebGL support on Windows ;)
Some Related PRs already merged in webrender and offscreen-gl-context:
servo/surfman#64
servo/webrender#432
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is