Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Add steps for windows-dev-yaml #13844

Closed
wants to merge 1 commit into from
Closed

[Do not merge] Add steps for windows-dev-yaml #13844

wants to merge 1 commit into from

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Oct 20, 2016 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because that is #13838

The new Buildbot configuration that reads steps from the servo repo
is currently failing on Windows, so add steps for a Windows test
builder to allow ironing out the kinks.

This change is Reviewable
@aneeshusa
Add steps for windows-dev-yaml
Loading status checks…
d4c9355 
The new Buildbot configuration that reads steps from the servo repo
is currently failing on Windows, so add steps for a Windows test
builder to allow ironing out the kinks.
@aneeshusa aneeshusa changed the title Add steps for windows-dev-yaml [Do not merge] Add steps for windows-dev-yaml Oct 20, 2016
@aneeshusa
Copy link
Member Author

aneeshusa commented Oct 20, 2016

I don't think this needs to actually be merged, I should be able to test things out via try builds.
@aneeshusa
Copy link
Member Author

aneeshusa commented Oct 20, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

⌛ Trying commit d4c9355 with merge 89cf6bb...
bors-servo added a commit that referenced this pull request Oct 20, 2016
@bors-servo
Auto merge of #13844 - aneeshusa:add-windows-dev-yaml-steps, r=<try>
Loading status checks…
89cf6bb 
[Do not merge] Add steps for windows-dev-yaml

<!-- Please describe your changes on the following line: -->

r? @larsbergstrom

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because that is #13838

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

The new Buildbot configuration that reads steps from the servo repo
is currently failing on Windows, so add steps for a Windows test
builder to allow ironing out the kinks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13844)
<!-- Reviewable:end -->
@aneeshusa aneeshusa mentioned this pull request Oct 20, 2016
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Oct 20, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/inline_block_opacity_change.html
  └   → /_mozilla/css/inline_block_opacity_change.html aed6845267bba6c52d3aa69c4889449b454d8117
/_mozilla/css/inline_block_opacity_change_ref.html febec1b4730afab195f280694dad47200b09ea3c
Testing aed6845267bba6c52d3aa69c4889449b454d8117 == febec1b4730afab195f280694dad47200b09ea3c
@aneeshusa
Copy link
Member Author

aneeshusa commented Oct 26, 2016

@bors-servo try
@KiChjang
Copy link
Member

KiChjang commented Oct 26, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2016

⌛ Trying commit d4c9355 with merge dff9c45...
bors-servo added a commit that referenced this pull request Oct 26, 2016
@bors-servo
Auto merge of #13844 - aneeshusa:add-windows-dev-yaml-steps, r=<try>
Loading status checks…
dff9c45 
[Do not merge] Add steps for windows-dev-yaml

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because that is #13838

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

The new Buildbot configuration that reads steps from the servo repo
is currently failing on Windows, so add steps for a Windows test
builder to allow ironing out the kinks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13844)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2016

💔 Test failed - linux-dev
@aneeshusa
Copy link
Member Author

aneeshusa commented Oct 26, 2016

@bors-servo retry

  • the annoying git
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2016

⌛ Trying commit d4c9355 with merge caaae66...
bors-servo added a commit that referenced this pull request Oct 26, 2016
@bors-servo
Auto merge of #13844 - aneeshusa:add-windows-dev-yaml-steps, r=<try>
Loading status checks…
caaae66 
[Do not merge] Add steps for windows-dev-yaml

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because that is #13838

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

The new Buildbot configuration that reads steps from the servo repo
is currently failing on Windows, so add steps for a Windows test
builder to allow ironing out the kinks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13844)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 26, 2016

💔 Test failed - linux-dev
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 27, 2016

@bors-servo retry

  • servo-linux2 out of disk space
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

⌛ Trying commit d4c9355 with merge 2ea3cdc...
bors-servo added a commit that referenced this pull request Oct 27, 2016
@bors-servo
Auto merge of #13844 - aneeshusa:add-windows-dev-yaml-steps, r=<try>
Loading status checks…
2ea3cdc 
[Do not merge] Add steps for windows-dev-yaml

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because that is #13838

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

The new Buildbot configuration that reads steps from the servo repo
is currently failing on Windows, so add steps for a Windows test
builder to allow ironing out the kinks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13844)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

💔 Test failed - linux-dev
@aneeshusa
Copy link
Member Author

aneeshusa commented Oct 27, 2016

This produced some successful windows-dev-yaml builds, so it looks like the saltfs dynamic steps work on Windows now, too. Watch servo/saltfs#522 for future updates.
@aneeshusa aneeshusa closed this Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@aneeshusa @bors-servo @highfive @KiChjang @larsbergstrom
You can’t perform that action at this time.