Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid some unnecessary clones when handling cookies. #13854

Merged
merged 1 commit into from Oct 20, 2016
Merged

Avoid some unnecessary clones when handling cookies. #13854

merged 1 commit into from Oct 20, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 20, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Avoid some unnecessary clones when handling cookies.
Loading status checks…
6bd5d27
@highfive
Copy link

highfive commented Oct 20, 2016

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Oct 20, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Oct 20, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

📌 Commit 6bd5d27 has been approved by emilio
@highfive highfive assigned emilio and unassigned mbrubeck Oct 20, 2016
@nox
Copy link
Member

nox commented Oct 20, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #13848
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

📌 Commit 6bd5d27 has been approved by nox
@highfive highfive assigned nox and unassigned emilio Oct 20, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

⌛ Testing commit 6bd5d27 with merge 5f3ad9b...
bors-servo added a commit that referenced this pull request Oct 20, 2016
@bors-servo
Auto merge of #13854 - servo:cookie-url-clones, r=nox
Loading status checks…
5f3ad9b 
Avoid some unnecessary clones when handling cookies.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13854)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

⛄ The build was interrupted to prioritize another pull request.
bors-servo added a commit that referenced this pull request Oct 20, 2016
@bors-servo
Auto merge of #13854 - servo:cookie-url-clones, r=nox
Loading status checks…
e77eccc 
Avoid some unnecessary clones when handling cookies.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13854)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

⌛ Testing commit 6bd5d27 with merge e77eccc...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 20, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 6bd5d27 into master Oct 20, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Oct 20, 2016
Closed
Merged
@notriddle notriddle deleted the cookie-url-clones branch Oct 20, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
31 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @emilio @bors-servo @nox @mbrubeck
You can’t perform that action at this time.