Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Try to conform a bit more to "The event loop processing model" #13864

Closed
wants to merge 3 commits into from
Closed

script: Try to conform a bit more to "The event loop processing model" #13864

wants to merge 3 commits into from

Conversation

@emilio
Copy link
Member

emilio commented Oct 21, 2016 •
edited by larsbergstrom

Let's see what breaks.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Oct 21, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/traversal.rs
  • @asajeffrey: components/constellation/constellation.rs
  • @fitzgen: components/script/dom/document.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_layout_interface/message.rs, components/script_traits/lib.rs, components/script_traits/lib.rs
  • @KiChjang: components/script/dom/document.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_layout_interface/message.rs, components/script_traits/lib.rs, components/script_traits/lib.rs
@emilio
Copy link
Member Author

emilio commented Oct 21, 2016

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2016

⌛ Trying commit 066bf68 with merge e49061c...
bors-servo added a commit that referenced this pull request Oct 21, 2016
@bors-servo
Auto merge of #13864 - emilio:event-loop, r=<try>
Loading status checks…
e49061c 
script: Try to conform a bit more to "The event loop processing model"

<!-- Please describe your changes on the following line: -->

Let's see what breaks.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bholley bholley mentioned this pull request Oct 21, 2016
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2016

💔 Test failed - linux-dev
@emilio emilio force-pushed the emilio:event-loop branch from 066bf68 to 31a9b41 Oct 21, 2016
@emilio
Copy link
Member Author

emilio commented Oct 21, 2016

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2016

⌛ Trying commit 31a9b41 with merge 1000d78...
bors-servo added a commit that referenced this pull request Oct 21, 2016
@bors-servo
Auto merge of #13864 - emilio:event-loop, r=<try>
Loading status checks…
1000d78 
script: Try to conform a bit more to "The event loop processing model"

<!-- Please describe your changes on the following line: -->

Let's see what breaks.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13864)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2016

💔 Test failed - mac-rel-wpt2
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2016

☔ The latest upstream changes (presumably #13848) made this pull request unmergeable. Please resolve the merge conflicts.
@emilio emilio force-pushed the emilio:event-loop branch from 31a9b41 to e24b30f Oct 21, 2016
@emilio
Copy link
Member Author

emilio commented Oct 21, 2016

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2016

⌛ Trying commit e24b30f with merge 4f6ad27...
bors-servo added a commit that referenced this pull request Oct 21, 2016
@bors-servo
Auto merge of #13864 - emilio:event-loop, r=<try>
Loading status checks…
4f6ad27 
script: Try to conform a bit more to "The event loop processing model"

<!-- Please describe your changes on the following line: -->

Let's see what breaks.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13864)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2016

💔 Test failed - linux-rel-wpt
@emilio emilio force-pushed the emilio:event-loop branch from e24b30f to ae85f54 Oct 21, 2016
@emilio
Copy link
Member Author

emilio commented Oct 21, 2016

@bors-servo: try

r? @Ms2ger
@highfive highfive assigned Ms2ger and unassigned KiChjang Oct 21, 2016
bors-servo added a commit that referenced this pull request Oct 21, 2016
@bors-servo
Auto merge of #13864 - emilio:event-loop, r=<try>
Loading status checks…
5ff7253 
script: Try to conform a bit more to "The event loop processing model"

<!-- Please describe your changes on the following line: -->

Let's see what breaks.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13864)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 21, 2016

⌛ Trying commit ae85f54 with merge 5ff7253...
@pcwalton
Copy link
Contributor

pcwalton commented Jan 31, 2017

This seems fine to me.
@jdm
Copy link
Member

jdm commented Jan 31, 2017

The concern in #13864 (comment) sounds exactly like #14972 which has been observed in the field.
@emilio
Copy link
Member Author

emilio commented Jan 31, 2017

@jdm that concern is pre-existing though, so I'll try to rebase this on top master. Addressing that shouldn't (hopefully) be extremely hard.
@ferjm ferjm mentioned this pull request Mar 13, 2017
Open
4 of 4 tasks complete
@emilio emilio force-pushed the emilio:event-loop branch from 0562cbb to 08808dc Mar 21, 2017
emilio added 3 commits Oct 20, 2016
@emilio
compositor: Ensure that script animation callbacks are always run aft…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
7307be4 
…er layout animations.

Per https://html.spec.whatwg.org/multipage/webappapis.html#run-css-animations-and-send-events
@emilio
style: fix tests/wpt/mozilla/tests/css/animations/basic-transition.ht…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
7bd16d7 
…ml so it is really deterministic and reports better errors.
@emilio
script: Try to conform a bit more to "The event loop processing model".
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
e04c72c 
This removes a set of hacks that we'd been piling up.
@emilio emilio force-pushed the emilio:event-loop branch from 08808dc to e04c72c Mar 21, 2017
@emilio
Copy link
Member Author

emilio commented Mar 21, 2017

@bors-servo try
1 similar comment
@nox
Copy link
Member

nox commented Mar 24, 2017

@bors-servo try
@nox
Copy link
Member

nox commented Mar 24, 2017

@bors-servo retry
@nox
Copy link
Member

nox commented Mar 24, 2017

Ok, this is what I suspected. This PR isn't even showing itself in Homu's queue at all.
@nox nox closed this Mar 24, 2017
@nox nox reopened this Mar 24, 2017
@nox
Copy link
Member

nox commented Mar 24, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

⌛ Trying commit e04c72c with merge 891b9a6...
bors-servo added a commit that referenced this pull request Mar 24, 2017
@bors-servo
Auto merge of #13864 - emilio:event-loop, r=<try>
Loading status checks…
891b9a6 
script: Try to conform a bit more to "The event loop processing model"

<!-- Please describe your changes on the following line: -->

Let's see what breaks.

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13864)

<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2017

💔 Test failed - linux-dev
@nox
Copy link
Member

nox commented Mar 24, 2017 

diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json
index 5d7438c..46c69ce 100644
--- a/tests/wpt/mozilla/meta/MANIFEST.json
+++ b/tests/wpt/mozilla/meta/MANIFEST.json
@@ -20010,7 +20010,7 @@
    "testharness"
   ],
   "css/animations/basic-transition.html": [
-   "6f4319854de92d7aee5ef425e17e80f9c39675df",
+   "4c1d67d8c180880c7e11c95979ef0f0346e8ce31",
    "testharness"
   ],
   "css/animations/mixed-units.html": [
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2017

☔ The latest upstream changes (presumably #16184) made this pull request unmergeable. Please resolve the merge conflicts.
@nox
Copy link
Member

nox commented Apr 4, 2017

What's the status on this?
@jdm
Copy link
Member

jdm commented Apr 12, 2017

#14972 is being solved by #16295. We should be sure that this PR does not introduce similar problems.
@emilio
Copy link
Member Author

emilio commented Apr 12, 2017

Yes, this shouldn't affect it. Thanks for fixing that @jdm!
@nox
Copy link
Member

nox commented Sep 24, 2017

Superseded by #18611.
@nox nox closed this Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcwalton pcwalton

Assignees

@pcwalton pcwalton

Labels
S-awaiting-review S-needs-code-changes S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@emilio @highfive @bors-servo @KiChjang @Ms2ger @jdm @pcwalton @nox
You can’t perform that action at this time.