Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStop ticking animations on non-dirty nodes during traversal #13866
Conversation
highfive
commented
Oct 21, 2016
|
r=me with that |
components/script/script_thread.rs
Outdated
| @@ -1536,6 +1536,7 @@ impl ScriptThread { | |||
| let node = unsafe { node.get_jsmanaged().get_for_script() }; | |||
| let window = window_from_node(node); | |||
|
|
|||
| node.dirty(NodeDamage::NodeStyleDamaged); | |||
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=emilio |
|
|
|
@bors-servo p=1 (another PR based on this one) |
bors-servo
added a commit
that referenced
this pull request
Oct 21, 2016
Stop ticking animations on non-dirty nodes during traversal See #13865. r? @emilio <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13866) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bholley commentedOct 21, 2016
•
edited by larsbergstrom
See #13865.
r? @emilio
This change is