Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl: Add basic support for framebuffer attachments #13872

Merged
merged 7 commits into from Oct 28, 2016

Commits on Oct 25, 2016

  1. webgl: Throw an error when binding a deleted framebuffer.

    The spec was recently changed to clarify that this should throw an
    error.
    anholt committed Oct 25, 2016

Commits on Oct 26, 2016

  1. webgl: Unbind deleted objects from the GL side, not just our side.

    Once FBOs are allowed, we were running into testcases that deleted the
    active FBO, and expected the following ReadPixels to come from the
    default framebuffer.
    anholt committed Oct 26, 2016
  2. webgl: Add support for checkFramebufferStatus().

    For now it's returning the default UNSUPPORTED on user FBOs.
    
    object-deletion-behaviour.html starts running a bunch more subtets.
    anholt committed Oct 26, 2016
  3. webgl: Add support for renderbufferStorage().

    This is not a complete implementation yet: It doesn't clear the
    contents of the renderbuffer on creation.  However, Gecko's plan to
    only clear renderbuffers when the first FBO using them is the
    simplest.
    anholt committed Oct 26, 2016
  4. webgl: Add support for FBO attachments.

    This allows many FBO tests to start running as their framebuffers
    start coming back as framebuffer complete.
    anholt committed Oct 26, 2016
  5. webgl: Detach RBs and textures from the bound FBO on deletion.

    This is part of general GL behavior: when an object is deleted, look
    through the currently bound objects and detach the deleted object from
    them.  Detaching an object from an FBO causes it to need to be
    re-checked for its status.
    anholt committed Oct 26, 2016
  6. webgl: Re-check FBO status on binding an FBO.

    When the FBO has been unbound, anything that happened to its
    attachments (deletion, new binding, reallocation) may have caused it
    to change status.
    
    This doesn't change any test results currently, because we're not
    checking if the attachments are deleted, the wrong size, or have
    appropriate formats.
    anholt committed Oct 26, 2016
You can’t perform that action at this time.