Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use str for bindgen output directly #13889

Merged
merged 1 commit into from Oct 24, 2016
Merged

Use str for bindgen output directly #13889

merged 1 commit into from Oct 24, 2016

Conversation

@upsuper
Copy link
Member

upsuper commented Oct 22, 2016 •
edited by larsbergstrom

r? @emilio

This change is Reviewable
@highfive
Copy link

highfive commented Oct 22, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/binding_tools/regen.py
  • @emilio: components/style/binding_tools/regen.py
@highfive
Copy link

highfive commented Oct 22, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Oct 22, 2016

@bors-servo: delegate+

03:14 <emilio> xidorn: what's the purpose of if ord(content[end]) & 0b11000000 != 0b10000000?
03:14 <xidorn> emilio: check whether it is a start byte of a codepoint in UTF-8
03:15 <xidorn> emilio: see https://en.wikipedia.org/wiki/UTF-8#Description
03:15 <emilio> xidorn: TIL that function existed :)
03:15 <xidorn> oh?
03:15 <xidorn> emilio: I actually wonder whether we could just print the str directly...
03:15 <xidorn> emilio: what would go wrong if we do that?
03:15 <emilio> xidorn: I'm not such a pythonist to be fair. I learn by need :P
03:16 <emilio> xidorn: It might just work?
03:16 <xidorn> emilio: probably? I can try :)
03:17 <emilio> xidorn: In any case, if it doesn't and you want to merge that one, r=me with a comment on that check. if it does, just r=me directly :)
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

✌️ @upsuper can now approve this pull request
@upsuper
Use str for bindgen output directly.
Loading status checks…
b7fffb3
@upsuper upsuper force-pushed the upsuper-forks:regen-output branch from 1cc1270 to b7fffb3 Oct 22, 2016
@upsuper upsuper changed the title Chunk large output of bindgen Use str for bindgen output directly Oct 22, 2016
@emilio
Copy link
Member

emilio commented Oct 23, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2016

📌 Commit b7fffb3 has been approved by emilio
bors-servo added a commit that referenced this pull request Oct 23, 2016
@bors-servo
Auto merge of #13889 - upsuper:regen-output, r=emilio
Loading status checks…
ff5d8be 
Use str for bindgen output directly

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13889)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2016

⌛ Testing commit b7fffb3 with merge ff5d8be...
@upsuper
Copy link
Member Author

upsuper commented Oct 23, 2016

Ah, I wanted to do some further test on my windows laptop before merging it... Anyway, I guess this change should be fine, so I guess it's okay to merge it now.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2016

💔 Test failed - linux-rel-css
@emilio
Copy link
Member

emilio commented Oct 23, 2016

I can hold it if you want, in any case, that failing test is #13887. Otherwise r=me yourself :)
@upsuper
Copy link
Member Author

upsuper commented Oct 23, 2016

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2016

📌 Commit b7fffb3 has been approved by emilio
@upsuper
Copy link
Member Author

upsuper commented Oct 23, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 23, 2016

⌛ Testing commit b7fffb3 with merge 6725454...
bors-servo added a commit that referenced this pull request Oct 23, 2016
@bors-servo
Auto merge of #13889 - upsuper:regen-output, r=emilio
Loading status checks…
6725454 
Use str for bindgen output directly

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13889)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit b7fffb3 into servo:master Oct 24, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:regen-output branch Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@upsuper @highfive @emilio @bors-servo
You can’t perform that action at this time.