Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate some glue #13890

Merged
merged 2 commits into from Oct 22, 2016
Merged

Auto-generate some glue #13890

merged 2 commits into from Oct 22, 2016

Conversation

@wafflespeanut
Copy link
Member

wafflespeanut commented Oct 22, 2016 •
edited by larsbergstrom

  • ./mach build-geckolib does not report any errors
  • These changes do not require tests because it's a refactor

r? @Manishearth or @emilio

This change is Reviewable
@highfive
Copy link

highfive commented Oct 22, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/properties/longhand/outline.mako.rs, components/style/properties/data.py
  • @emilio: components/style/properties/gecko.mako.rs, components/style/properties/longhand/outline.mako.rs, components/style/properties/data.py
@highfive
Copy link

highfive commented Oct 22, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@wafflespeanut wafflespeanut force-pushed the wafflespeanut:glue branch from 8d6ecda to 94758b2 Oct 22, 2016
@Manishearth
Manishearth approved these changes Oct 22, 2016
View changes
Copy link
Member

Manishearth left a comment

r=me
components/style/properties/gecko.mako.rs Outdated
}

keyword_longhands = [x for x in longhands if x.keyword and not x.name in force_stub]
def predefined_type_method(longhand=None):
if longhand is None:

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Oct 22, 2016

Member

why default longhand to None in the first place?

This comment has been minimized.

Sign in to view
@wafflespeanut

wafflespeanut Oct 22, 2016

Author Member

yeah, that's not necessary :)
@wafflespeanut
Minor codegen refactor for auto-generating some predefined types
caa745c
@wafflespeanut wafflespeanut force-pushed the wafflespeanut:glue branch from 94758b2 to b2be0f5 Oct 22, 2016
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Oct 22, 2016

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

📌 Commit b2be0f5 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

⌛ Testing commit b2be0f5 with merge 7e1e540...
bors-servo added a commit that referenced this pull request Oct 22, 2016
@bors-servo
Auto merge of #13890 - Wafflespeanut:glue, r=Manishearth
Loading status checks…
7e1e540 
Auto-generate some glue

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build-geckolib` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because it's a refactor

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @Manishearth or @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13890)
<!-- Reviewable:end -->
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Oct 22, 2016 •
edited

@bors-servo r=Manishearth

(minor fix)
@wafflespeanut
Auto-generate color glue
Loading status checks…
b446f0e
@wafflespeanut wafflespeanut force-pushed the wafflespeanut:glue branch from b2be0f5 to b446f0e Oct 22, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

📌 Commit b446f0e has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

⌛ Testing commit b446f0e with merge 97feac0...
bors-servo added a commit that referenced this pull request Oct 22, 2016
@bors-servo
Auto merge of #13890 - Wafflespeanut:glue, r=Manishearth
Loading status checks…
97feac0 
Auto-generate some glue

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build-geckolib` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because it's a refactor

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @Manishearth or @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13890)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

💔 Test failed - mac-rel-css
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Oct 22, 2016

@bors-servo retry #13887
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

💔 Test failed - mac-rel-css
@wafflespeanut
Copy link
Member Author

wafflespeanut commented Oct 22, 2016

@bors-servo retry #13887
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit b446f0e into servo:master Oct 22, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 22, 2016
Merged
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@wafflespeanut @highfive @bors-servo @Manishearth
You can’t perform that action at this time.